Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make numba 0.58 the minimum supported version #1307

Merged
merged 2 commits into from
Feb 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions conda-recipe/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,15 @@ requirements:
- scikit-build >=0.15*
- ninja # [not win]
- cmake >=3.26*
- numba >=0.57*
- numba >=0.58*
- dpctl >=0.14*
- dpnp >=0.11*
- dpcpp-llvm-spirv
- wheel
run:
- {{ pin_compatible('dpcpp-cpp-rt', min_pin='x.x', max_pin='x') }}
- python
- numba >=0.57*
- numba >=0.58*
- dpctl >=0.14*
- dpcpp-llvm-spirv
- dpnp >=0.11*
Expand Down
8 changes: 2 additions & 6 deletions numba_dpex/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,18 +67,14 @@ def parse_sem_version(version_string: str) -> Tuple[int, int, int]:


numba_sem_version = parse_sem_version(numba_version)
if numba_sem_version < (0, 57, 0) or numba_sem_version >= (0, 59, 0):
if numba_sem_version < (0, 58, 0) or numba_sem_version >= (0, 59, 0):
logging.warning(
"numba_dpex needs at least numba 0.57.0 but no more than 0.59.0, using "
"numba_dpex needs at least numba 0.58.0 but no more than 0.59.0, using "
f"numba={numba_version} may cause unexpected behavior"
)

# Monkey patches
patch_is_ufunc.patch()
if numba_sem_version < (0, 58, 0):
from .numba_patches import patch_mk_alloc

patch_mk_alloc.patch()
patch_arrayexpr_tree_to_ir.patch()

dpctl_sem_version = parse_sem_version(dpctl.__version__)
Expand Down
175 changes: 0 additions & 175 deletions numba_dpex/numba_patches/patch_mk_alloc.py

This file was deleted.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ requires = [
"scikit-build>=0.13",
"cmake>=3.18",
"ninja",
"numba>=0.57",
"numba>=0.58",
"versioneer-518"
]
build-backend = "setuptools.build_meta"
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def to_cmake_format(version: str):
platforms=["Linux", "Windows"],
author="Intel Corporation",
url="https://github.com/IntelPython/numba-dpex",
install_requires=["numba >={0:s}".format("0.57"), "dpctl", "packaging"],
install_requires=["numba >={0:s}".format("0.58"), "dpctl", "packaging"],
packages=find_packages("."),
include_package_data=True,
zip_safe=False,
Expand Down
Loading