Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PrivateArray kernel_api #1370

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Add PrivateArray kernel_api #1370

merged 1 commit into from
Mar 4, 2024

Conversation

ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Mar 1, 2024 •
edited
Loading

Creates PrivateArray class that is used inside kernel_api. Overloaded with USMNdArray instance generation on stack.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa self-assigned this Mar 1, 2024
@ZzEeKkAa ZzEeKkAa force-pushed the feature/private_array branch 2 times, most recently from c2c22a5 to ade28e8 Compare March 1, 2024 23:32
@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review March 1, 2024 23:37
@ZzEeKkAa ZzEeKkAa requested a review from diptorupd March 1, 2024 23:38
diptorupd
diptorupd suggested changes Mar 2, 2024
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few technical questions. The docstrings all have copypasta issues.

numba_dpex/experimental/_kernel_dpcpp_spirv_overloads/_private_array_overloads.py Outdated Show resolved Hide resolved
numba_dpex/experimental/_kernel_dpcpp_spirv_overloads/_private_array_overloads.py Outdated Show resolved Hide resolved
numba_dpex/experimental/_kernel_dpcpp_spirv_overloads/_private_array_overloads.py Outdated Show resolved Hide resolved
numba_dpex/experimental/_kernel_dpcpp_spirv_overloads/_private_array_overloads.py Outdated Show resolved Hide resolved
numba_dpex/kernel_api/private_array.py Outdated Show resolved Hide resolved
numba_dpex/kernel_api/private_array.py Outdated Show resolved Hide resolved
numba_dpex/kernel_api/private_array.py Outdated Show resolved Hide resolved
numba_dpex/kernel_api/private_array.py Outdated Show resolved Hide resolved
numba_dpex/kernel_api_impl/spirv/arrayobj.py Show resolved Hide resolved
numba_dpex/kernel_api_impl/spirv/arrayobj.py Show resolved Hide resolved
@ZzEeKkAa ZzEeKkAa force-pushed the feature/private_array branch 3 times, most recently from a2b0120 to 6e03083 Compare March 4, 2024 18:07
@ZzEeKkAa ZzEeKkAa requested a review from diptorupd March 4, 2024 18:10
@ZzEeKkAa ZzEeKkAa force-pushed the feature/private_array branch from 6e03083 to 328f8ed Compare March 4, 2024 18:12
@ZzEeKkAa ZzEeKkAa force-pushed the feature/private_array branch from 328f8ed to b550f42 Compare March 4, 2024 18:14
diptorupd
diptorupd approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@diptorupd diptorupd merged commit be68c49 into main Mar 4, 2024
63 of 65 checks passed
@diptorupd diptorupd deleted the feature/private_array branch March 4, 2024 19:52
github-actions bot added a commit that referenced this pull request Mar 4, 2024
@github-actions
Merge pull request #1370 from IntelPython/feature/private_array
fc98a52 
Add PrivateArray kernel_api be68c49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

@oleksandr-pavlyk oleksandr-pavlyk Awaiting requested review from oleksandr-pavlyk

Assignees

@ZzEeKkAa ZzEeKkAa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZzEeKkAa @diptorupd