Ts mono unifiedmaps #2584
Merged
Ts mono unifiedmaps #2584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimSheard
force-pushed
the
ts-mono-unifiedmaps
branch
from
e5c53a8 to
b32183d
Compare
TimSheard
commented
Dec 16, 2021
eras/shelley/test-suite/src/Test/Cardano/Ledger/Shelley/Generator/Trace/Chain.hs
Outdated
Show resolved
Hide resolved
TimSheard
commented
Dec 16, 2021
TimSheard
commented
Dec 16, 2021
TimSheard
commented
Dec 16, 2021
There was a problem hiding this comment.
@TimSheard this really is a great abstraction! It's fantastic how the new code reads so similar to the old! I only had a few trivial comments. I'll wait to approve until my eyes have a change to go over this. Thanks for all this hard work!
lehins
requested changes
Dec 21, 2021
TimSheard
force-pushed
the
ts-mono-unifiedmaps
branch
from
6b7ed2e to
3aca069
Compare
TimSheard
force-pushed
the
ts-mono-unifiedmaps
branch
4 times, most recently
from
5a5c3fc to
972b127
Compare
This replaces 3 separate Data.Map in DState, with 1 UnifiedMap. Added SetAlgebra instances for UMap. Added libs/cardano-data/src/Data/MapExtras.hs which provide operation on Data.Map not available i the standard library. Rewrote incrementalStakeDistr to use the Unified reward maps. Added 50 property tests for UMap. Added the space saving Trip data and Triple pattern.
TimSheard
force-pushed
the
ts-mono-unifiedmaps
branch
from
0c7038b to
bdf8df5
Compare
lehins
pushed a commit
to lehins/cardano-ledger
that referenced
this pull request
Apr 11, 2022
…ntersectMBO#2584) This replaces 3 separate Data.Map in DState, with 1 UnifiedMap. Added SetAlgebra instances for UMap. Added libs/cardano-data/src/Data/MapExtras.hs which provide operation on Data.Map not available i the standard library. Rewrote incrementalStakeDistr to use the Unified reward maps. Added 50 property tests for UMap. Added the space saving Trip data and Triple pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces UnifiedMap, ViewMap, Triple
Adds SetAlgebra Instances
Adds FromSharedCBOR instances
Fixes files so the new types are actually used