Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert back accidental refactor of module VMap to ViewMap #2607

Merged
merged 1 commit into from
Jan 6, 2022
Merged

Revert back accidental refactor of module VMap to ViewMap #2607

merged 1 commit into from
Jan 6, 2022
+23 −23

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Jan 6, 2022

In #2584 there was a new concept introduced called ViewMap. Accidentally unrelated VMap module got renamed to ViewMap. This PR reverts that change

@lehins lehins requested a review from TimSheard January 6, 2022 22:14
TimSheard
TimSheard approved these changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@TimSheard TimSheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR reverts a bunch of name changes to Data.VMap. It consists almost exclusively of slight changes to import statements. It should have no effect on the executable code. We should run the tests just to be sure. If they pass this shoud be safe to merge.

@lehins lehins merged commit c074986 into master Jan 6, 2022
@iohk-bors iohk-bors bot deleted the lehins/revert-accidental-vmap-refactor branch January 6, 2022 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimSheard TimSheard TimSheard approved these changes

@JaredCorduan JaredCorduan JaredCorduan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lehins @JaredCorduan @TimSheard