-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tools for constrained generation of types that need witnessing #4732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dad09c4
to
79528fb
Compare
97d3a82
to
eaf2d94
Compare
66f5096
to
a2b8b53
Compare
937a10c
to
6f4713d
Compare
MaximilianAlgehed
approved these changes
Dec 5, 2024
9451ca0
to
06d0007
Compare
Soupstraw
reviewed
Dec 6, 2024
libs/cardano-ledger-conformance/test/Test/Cardano/Ledger/Conformance/Spec/Conway.hs
Outdated
Show resolved
Hide resolved
Soupstraw
reviewed
Dec 6, 2024
libs/cardano-ledger-conformance/test/Test/Cardano/Ledger/Conformance/ExecSpecRule/MiniTrace.hs
Outdated
Show resolved
Hide resolved
Soupstraw
reviewed
Dec 6, 2024
Soupstraw
reviewed
Dec 6, 2024
Soupstraw
reviewed
Dec 6, 2024
libs/cardano-ledger-conformance/src/Test/Cardano/Ledger/Conformance/ExecSpecRule/Conway/Cert.hs
Outdated
Show resolved
Hide resolved
Soupstraw
reviewed
Dec 6, 2024
.../cardano-ledger-conformance/src/Test/Cardano/Ledger/Conformance/ExecSpecRule/Conway/Certs.hs
Outdated
Show resolved
Hide resolved
Soupstraw
reviewed
Dec 6, 2024
.../cardano-ledger-conformance/src/Test/Cardano/Ledger/Conformance/ExecSpecRule/Conway/Deleg.hs
Outdated
Show resolved
Hide resolved
Soupstraw
reviewed
Dec 6, 2024
...ardano-ledger-conformance/src/Test/Cardano/Ledger/Conformance/ExecSpecRule/Conway/GovCert.hs
Outdated
Show resolved
Hide resolved
Soupstraw
reviewed
Dec 6, 2024
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Conway/LedgerTypes/Tests.hs
Outdated
Show resolved
Hide resolved
Soupstraw
reviewed
Dec 6, 2024
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Conway/Deleg.hs
Show resolved
Hide resolved
892eacd
to
162907c
Compare
9 tasks
162907c
to
3ca5487
Compare
lehins
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor suggestions and questions
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Conway/Instances/Ledger.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Conway/LedgerTypes/Specs.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Conway/LedgerTypes/Specs.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Conway/ParametricSpec.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Conway/ParametricSpec.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Conway/WitnessUniverse.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Conway/WitnessUniverse.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Conway/WitnessUniverse.hs
Outdated
Show resolved
Hide resolved
08d0947
to
4a8d9b1
Compare
Added the Witness class, and many instances. Improved Specs to require witnesses where needed. WitUniv used in DELEG POOL GOVCERT CERT and CERTS conformance rules
479a911
to
c0000cb
Compare
lehins
reviewed
Dec 18, 2024
c0000cb
to
3a57c95
Compare
lehins
reviewed
Dec 18, 2024
lehins
reviewed
Dec 18, 2024
…ecification is failing. Add some property tests that conformsToSpec and conformsToSpecE report the "same" results.
3a57c95
to
928b27c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress. Comment requested to be sure we build a usable set of tools.
When we write generators the TxBody, we need to make sure that some of the types generated can be witnessed.
Most types that need witnessing are hashes, just generating a random hash will not do, since that hash has to be the
hash of an actual object that we can compute, given the hash. Since that usually impossible, we will have do it backwards,
i.e. generate the object, then return the hash, and remember the association for when it comes time to produce the witness.
This is the role of the data WitUniv.
Checklist
CHANGELOG.md
for the affected packages.New section is never added with the code changes. (See RELEASING.md)
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated.If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)