Ts constrained witnessing take2 #4799
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the Witness class, and many instances. Improved Specs to require witnesses where needed. WitUniv used in DELEG POOL GOVCERT CERT and CERTS conformance rules
…ecification is failing. Add some property tests that conformsToSpec and conformsToSpecE report the "same" results.
TimSheard
force-pushed
the
ts-constrained-witnessingTake2
branch
from
93b08ba to
3ca5487
Compare
|
Changes here were rolled into PR #4732 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variant on PR #4732, picks up where things went wrong rebasing on master where parameterization on Crypto was removed.
When we write generators the TxBody, we need to make sure that some of the types generated can be witnessed.
Most types that need witnessing are hashes, just generating a random hash will not do, since that hash has to be the
hash of an actual object that we can compute, given the hash. Since that usually impossible, we will have do it backwards,
i.e. generate the object, then return the hash, and remember the association for when it comes time to produce the witness.
This is the role of the data WitUniv.
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changesNew section is never added with the code changes. (See RELEASING.md)
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessaryIf you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
scripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlupdated (usescripts/gen-hie.sh)