Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

138 user registration report #144

Merged
merged 13 commits into from
Nov 22, 2024
Merged

138 user registration report #144

merged 13 commits into from
Nov 22, 2024

Conversation

malkin0xb8
Copy link
Collaborator

No description provided.

@malkin0xb8 malkin0xb8 added the enhancement New feature or request label Nov 15, 2024
@malkin0xb8 malkin0xb8 linked an issue Nov 15, 2024 that may be closed by this pull request
User Registration Report #138
Closed
Jordan-Prescott
Jordan-Prescott requested changes Nov 18, 2024
View reviewed changes
Copy link
Owner

@Jordan-Prescott Jordan-Prescott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work guys just a couple of code smells to refactor and some learning moments.

odins_spear/scripts/user_registration.py Outdated Show resolved Hide resolved
odins_spear/scripts/user_registration.py Outdated Show resolved Hide resolved
odins_spear/scripts/user_registration.py Outdated Show resolved Hide resolved
odins_spear/scripts/user_registration.py Outdated Show resolved Hide resolved
odins_spear/scripts/user_registration.py Outdated Show resolved Hide resolved
odins_spear/reports/user_registration_report.py Outdated Show resolved Hide resolved
odins_spear/reports/user_registration_report.py Outdated Show resolved Hide resolved
Jordan-Prescott
Jordan-Prescott requested changes Nov 20, 2024
View reviewed changes
Copy link
Owner

@Jordan-Prescott Jordan-Prescott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes needed guys but looking really good.

odins_spear/reporter.py Show resolved Hide resolved
odins_spear/reports/user_registration_report.py Show resolved Hide resolved
odins_spear/scripts/user_registration.py Outdated Show resolved Hide resolved
odins_spear/scripts/user_registration.py Outdated Show resolved Hide resolved
odins_spear/scripts/user_registration.py Outdated Show resolved Hide resolved
@Jordan-Prescott Jordan-Prescott merged commit e686138 into main Nov 22, 2024
1 check passed
@Jordan-Prescott Jordan-Prescott deleted the 138-user-registration-report branch November 22, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jordan-Prescott Jordan-Prescott Jordan-Prescott approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Odin's Spear - Use Your Best Weapon.
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User Registration Report
3 participants
@malkin0xb8 @Jordan-Prescott @KiPageFault