-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add register_error_hint for UndefVarError #39850
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, I just include the show_error_hints part from #39089 Further relevant discussion in [discourse](https://discourse.julialang.org/t/help-with-register-error-hint/56140/4)
You need to copy over the changes to |
simeonschaub
approved these changes
Feb 27, 2021
Sorry I did not get back to this! Feel free to regularly bump PRs in the future, so they don't get forgotten. |
simeonschaub
removed
the
merge me
PR is reviewed. Merge when all tests are passing
label
Apr 3, 2021
@simeonschaub when you merge PRs, please confirm the commit message is correct. It looks like you added co-authored-by and other noise which aren't useful. |
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
* add show_error_hints for UndefVarError Hi, I just include the show_error_hints part from JuliaLang#39089 Further relevant discussion in [discourse](https://discourse.julialang.org/t/help-with-register-error-hint/56140/4) * Update errorshow.jl * Update Base.jl Co-authored-by: Simeon Schaub <[email protected]>
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
* add show_error_hints for UndefVarError Hi, I just include the show_error_hints part from JuliaLang#39089 Further relevant discussion in [discourse](https://discourse.julialang.org/t/help-with-register-error-hint/56140/4) * Update errorshow.jl * Update Base.jl Co-authored-by: Simeon Schaub <[email protected]>
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
* add show_error_hints for UndefVarError Hi, I just include the show_error_hints part from JuliaLang#39089 Further relevant discussion in [discourse](https://discourse.julialang.org/t/help-with-register-error-hint/56140/4) * Update errorshow.jl * Update Base.jl Co-authored-by: Simeon Schaub <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I just include the show_error_hints part from #39089
Further relevant discussion in discourse