Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add register_error_hint for UndefVarError #39850

Merged
merged 4 commits into from
Apr 3, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'master' into master
simeonschaub authored Apr 3, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 337ee15e9dbcfbd6359828a5026100795314a193
26 changes: 26 additions & 0 deletions test/errorshow.jl
Original file line number Diff line number Diff line change
@@ -765,4 +765,30 @@ let err = nothing
end
end

# issue #37587
# TODO: enable on more platforms
if Sys.isapple() || (Sys.islinux() && Sys.ARCH === :x86_64)
single_repeater() = single_repeater()
pair_repeater_a() = pair_repeater_b()
pair_repeater_b() = pair_repeater_a()

@testset "repeated stack frames" begin
let bt = try single_repeater()
catch
catch_backtrace()
end
bt_str = sprint(Base.show_backtrace, bt)
@test occursin(r"repeats \d+ times", bt_str)
end

let bt = try pair_repeater_a()
catch
catch_backtrace()
end
bt_str = sprint(Base.show_backtrace, bt)
@test occursin(r"the last 2 lines are repeated \d+ more times", bt_str)
end
end
end # Sys.isapple()

@test contains(sprint(Base.showerror, UndefVarError(:UTF16String)), "LegacyStrings")
You are viewing a condensed version of this merge commit. You can view the full changes here.