Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openblas] Build the BFloat16 kernels in OpenBLAS #7168

Closed
wants to merge 2 commits into from

Conversation

ViralBShah
Copy link
Member

@ViralBShah ViralBShah commented Aug 5, 2023

@ViralBShah ViralBShah changed the title [openblas] Build the FBloat16 kernels in OpenBLAS [openblas] Build the BFloat16 kernels in OpenBLAS Aug 5, 2023
@ViralBShah ViralBShah marked this pull request as draft August 5, 2023 12:10
@ViralBShah
Copy link
Member Author

@giordano @staticfloat It would be really nice to be able to build with BFloat16. I've bumped to the highest GCC, but still failing all over the place.

@imciner2
Copy link
Member

The x86_64 errors are a build system problem, upstream fix in OpenMathLib/OpenBLAS#4192. It doesn't apply cleanly to the 0.3.23 source though, but I have a local patch that adds it (tested on the x86_64-apple-darwin-libgfortran3 and x86_64-unknown-freebsd-libgfortran5 targets, but it should work on the other x86_64 targets where the problem was the cooperlake detection). I can't push the patch to the branch though, how would you like me to add it?

@ViralBShah
Copy link
Member Author

My PR is actually quite small. So I'll close it - can you open a new PR?

@ViralBShah ViralBShah closed this Aug 14, 2023
@giordano giordano deleted the vs/openblas-bfp16 branch September 3, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants