Fix cooperlake and sapphire rapids march flags on clang #4192
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
march=cooperlake
andmarch=sapphirerapids
flags were never getting added when building with Clang targetting those architectures. Instead it was falling back to the skylake AVX512 implementation. This was causing issues when building configurations such asbecause there was either no
march
on the compiler command, or it wasmarch=skylake-avx512 -mavx512f
, neither of which would support the bfloat intrinsics needed, leading to errors likeor
Clang added support for these two architectures in Clang 9 and Clang 12, so introduce new checks for those versions to enable the appropriate march flag, and fallback to skylake otherwise.