-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDPA] rebuild for Julia 1.10 #7902
Conversation
@blegat any ideas? |
For the macOS build error:
Try putting |
Hmm, there was a comment in a recent commit for a package that also links against cxxwrap about using the same version of |
Alternately, there was a similar issue as this in the main Julia JLL build and the CSL build, and that required some file hackery apparently, so this is something else to try: https://github.com/JuliaPackaging/Yggdrasil/pull/7484/files#diff-29b8d08819b1a971a0a4f552117850f0569b1947bc3390d698455c6e3b7557b7R297 |
Co-authored-by: Ian McInerney <[email protected]>
S/SDPA/build_tarballs.jl
Outdated
@@ -71,6 +71,11 @@ elif [[ ${target} == *linux* ]]; then | |||
export LDFLAGS="-ldl -lrt" | |||
fi | |||
|
|||
# work around missing strtoll strtoull, see https://github.com/JuliaLang/julia/issues/48081 | |||
if [[ "${target}" == *mingw* ]]; then | |||
cp /opt/*-w64-mingw32/*-w64-mingw32/sys-root/lib/libmsvcrt.a /usr/lib/libmsvcrt.a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What am I doing wrong? Where should /usr/lib/libmsvcrt.a
actually go?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than copying the file, add /opt/*-w64-mingw32/*-w64-mingw32/sys-root/lib
to LDFLAGS
? But I'm surprised that directory isn't already in the default search path of the compiler, I'm fairly sure it should be.
One thing I noticed:
Is there any reason it is using 1.7? |
I believe that Binary builder has some issues with later versions that haven't been fully sorted out yet. |
Closing in favor of #8130 |
I get this error with Julia 1.10 jump-dev/SDPA.jl#57, jump-dev/SDPA.jl#56:
Which I assume means I just need to recompile things. I don't really understand
cxxwrap
.