Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDPA] rebuild for Julia 1.10 #7902

Closed
wants to merge 7 commits into from
Closed

Conversation

odow
Copy link
Contributor

@odow odow commented Jan 3, 2024

I get this error with Julia 1.10 jump-dev/SDPA.jl#57, jump-dev/SDPA.jl#56:

LoadError: InitError: could not load library "/home/runner/.julia/artifacts/beeb384c8ba60497d81e26a28f74ed99aef88791/lib/libcxxwrap_julia.so"
/home/runner/.julia/artifacts/beeb384c8ba60497d81e26a28f74ed99aef88791/lib/libcxxwrap_julia.so: undefined symbol: small_typeof, version JL_LIBJULIA_1.10

Which I assume means I just need to recompile things. I don't really understand cxxwrap.

@odow
Copy link
Contributor Author

odow commented Jan 4, 2024

@blegat any ideas?

@imciner2
Copy link
Member

imciner2 commented Jan 4, 2024

For the macOS build error:

[22:11:06] ld64.lld: warning: Option `-keep_private_externs' is not yet implemented. Stay tuned...
[22:11:06] ld64.lld: warning: Option `-r' is not yet implemented. Stay tuned...
[22:11:06] ld64.lld: warning: Option `-r' is not yet implemented. Stay tuned...
[22:11:06] ld64.lld: error: undefined symbol: main
[22:11:06] >>> referenced by the entry point
...

Try putting clang_use_lld=false in the build_tarballs() call.

@imciner2
Copy link
Member

imciner2 commented Jan 5, 2024

[23:42:24] /opt/i686-w64-mingw32/bin/../i686-w64-mingw32/sys-root/lib/../lib/libmingwex.a(lib32_libmingwex_a-mingw_vfscanf.o): In function `_mingw_sformat':
[23:42:24] /workspace/srcdir/mingw-w64-v11.0.1/mingw-w64-crt/stdio/mingw_vfscanf.c:1081: undefined reference to `strtoll'
[23:42:24] /workspace/srcdir/mingw-w64-v11.0.1/mingw-w64-crt/stdio/mingw_vfscanf.c:1083: undefined reference to `strtoull'
[23:42:24] collect2: error: ld returned 1 exit status
[23:42:24] make[1]: *** [Makefile:650: libsdpa.la] Error 1

Hmm, there was a comment in a recent commit for a package that also links against cxxwrap about using the same version of libjulia_jll and GCC as the libcxxwrap-julia package does (57c0ba2). Maybe try that to fix the mingw errors?

@imciner2
Copy link
Member

imciner2 commented Jan 5, 2024

Alternately, there was a similar issue as this in the main Julia JLL build and the CSL build, and that required some file hackery apparently, so this is something else to try: https://github.com/JuliaPackaging/Yggdrasil/pull/7484/files#diff-29b8d08819b1a971a0a4f552117850f0569b1947bc3390d698455c6e3b7557b7R297

S/SDPA/build_tarballs.jl Outdated Show resolved Hide resolved
S/SDPA/build_tarballs.jl Outdated Show resolved Hide resolved
@@ -71,6 +71,11 @@ elif [[ ${target} == *linux* ]]; then
export LDFLAGS="-ldl -lrt"
fi

# work around missing strtoll strtoull, see https://github.com/JuliaLang/julia/issues/48081
if [[ "${target}" == *mingw* ]]; then
cp /opt/*-w64-mingw32/*-w64-mingw32/sys-root/lib/libmsvcrt.a /usr/lib/libmsvcrt.a
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What am I doing wrong? Where should /usr/lib/libmsvcrt.a actually go?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than copying the file, add /opt/*-w64-mingw32/*-w64-mingw32/sys-root/lib to LDFLAGS? But I'm surprised that directory isn't already in the default search path of the compiler, I'm fairly sure it should be.

@odow
Copy link
Contributor Author

odow commented Jan 11, 2024

One thing I noticed:

Downloading Julia 1.7 for arch x86_64

Is there any reason it is using 1.7?

@imciner2
Copy link
Member

Is there any reason it is using 1.7?

I believe that Binary builder has some issues with later versions that haven't been fully sorted out yet.

@odow
Copy link
Contributor Author

odow commented Feb 21, 2024

Closing in favor of #8130

@odow odow closed this Feb 21, 2024
@odow odow deleted the patch-2 branch February 21, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants