Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDPA] rebuild for Julia 1.10 #8130

Merged
merged 30 commits into from
Feb 21, 2024
Merged

[SDPA] rebuild for Julia 1.10 #8130

merged 30 commits into from
Feb 21, 2024

Conversation

blegat
Copy link
Contributor

@blegat blegat commented Feb 19, 2024

Rebase of #7902 and update SDPA

@@ -27,7 +27,7 @@ julia_compat = join("~" .* string.(getfield.(julia_versions, :major)) .* "." .*

name = "SDPA"
upstream_version = v"7.3.8"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we also need to update to a more recent SDPA version

@imciner2
Copy link
Member

If you want MUMPS 5.4.1, you will need to only support Julia 1.8+ and drop Julia 1.6 (LTS) and 1.7 due to it having a compat for that: https://github.com/JuliaRegistries/General/blob/master/jll/M/MUMPS_seq_jll/Compat.toml#L26C1-L27C18

@blegat
Copy link
Contributor Author

blegat commented Feb 21, 2024

Is there any way to obtain i686-w64-mingw32 inside the build script, I tried MACHTYPE but it gives me x86_64-linux-musl

@imciner2
Copy link
Member

Is there any way to obtain i686-w64-mingw32 inside the build script, I tried MACHTYPE but it gives me x86_64-linux-musl

Look at the ${target} variable.

You can look through some other scripts in Ygg to see how you can glob it, e.g. https://github.com/JuliaPackaging/Yggdrasil/blob/master/O/OpenBLAS/common.jl.

S/SDPA/build_tarballs.jl Outdated Show resolved Hide resolved
@blegat
Copy link
Contributor Author

blegat commented Feb 21, 2024

I removed it and it still works so it didn't seem needed, looks good to merge from my side

@giordano giordano merged commit 2f6d0e8 into JuliaPackaging:master Feb 21, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants