Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show a placeholder when there are no visible routes #362

Closed
lordrip opened this issue Nov 17, 2023 · 7 comments · Fixed by #681
Closed

Show a placeholder when there are no visible routes #362

lordrip opened this issue Nov 17, 2023 · 7 comments · Fixed by #681
Assignees
@lordrip
Labels
canvas/visualization Canvas-related issues enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone
2.0.0 TP1

Comments

@lordrip
Copy link
Member

lordrip commented Nov 17, 2023

Please describe the feature that you want to propose

When there are no visible routes in the canvas, either because they don't exist or all are hidden, it would be convenient to show a placeholder to explain to the user why nothing is visible in the canvas

No defined routes

image

No visible routes

image

Notes

Here's the implementation in kaoto v1
@lordrip lordrip added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed canvas/visualization Canvas-related issues labels Nov 17, 2023
@lordrip lordrip added this to the Polishing UI-UX post parity milestone Nov 17, 2023
@bilalshaikh292
Copy link

heyy is the issue still open ? I would like to contribute ?

@lhein
Copy link
Contributor

lhein commented Nov 17, 2023

Your help is very welcome.

@lhein lhein moved this from New to Todo in Kanban Board Nov 17, 2023
@lhein lhein moved this from Todo to In Progress in Kanban Board Nov 17, 2023
@lordrip
Copy link
Member Author

lordrip commented Jan 8, 2024

Hi @bilalshaikh292 😃 , did you have the chance to take a look into this?

@bilalshaikh292
Copy link

yes Sure I will Give this a try

lordrip added a commit to lordrip/kaoto that referenced this issue Jan 19, 2024
@lordrip
feat(canvas): Show placeholder when there are no visible flows
c3abcb8 
Currently, when the canvas is empty, being because there are no flows
defined or because there are but hidden, we see a gray area. This might
present an issue for the users, starting with a blank file in VSCode, as
it's not clear what's the first step to start working with the app.

This commit introduces a placeholder in case there are no flows or there
are but not visible

fix: KaotoIO#362
@lordrip lordrip mentioned this issue Jan 19, 2024
Merged
@lordrip
Copy link
Member Author

lordrip commented Jan 19, 2024

Thanks @bilalshaikh292 for your interest in this issue 💪 , since we're approaching an upcoming release, we need to have this implemented a bit sooner than expected, sorry for that.

In any case, you're always welcome to contribute to any issue that is interesting to you.

Implementing it here: #681

@lordrip lordrip assigned lordrip and unassigned bilalshaikh292 Jan 19, 2024
@lordrip lordrip modified the milestones: 2.0.0, 2.0.0 TP1 Jan 19, 2024
@lordrip lordrip moved this from In Progress to In Review in Kanban Board Jan 19, 2024
lordrip added a commit to lordrip/kaoto that referenced this issue Jan 19, 2024
@lordrip
feat(canvas): Show placeholder when there are no visible flows
e279e9d 
Currently, when the canvas is empty, being because there are no flows
defined or because there are but hidden, we see a gray area. This might
present an issue for the users, starting with a blank file in VSCode, as
it's not clear what's the first step to start working with the app.

This commit introduces a placeholder in case there are no flows or there
are but not visible

fix: KaotoIO#362
@bilalshaikh292
Copy link

heyy @lordrip sorry for the inconvenience I have been a little busy and was already assigned a issue in another organizarion prior to this issue .Sorry for not updating . I will look for another issue,Thanks

lordrip added a commit to lordrip/kaoto that referenced this issue Jan 22, 2024
@lordrip
feat(canvas): Show placeholder when there are no visible flows
1e18f2e 
Currently, when the canvas is empty, being because there are no flows
defined or because there are but hidden, we see a gray area. This might
present an issue for the users, starting with a blank file in VSCode, as
it's not clear what's the first step to start working with the app.

This commit introduces a placeholder in case there are no flows or there
are but not visible

fix: KaotoIO#362
@lordrip
Copy link
Member Author

lordrip commented Jan 22, 2024

Hi @bilalshaikh292, no worries at all, thanks once again for your interest 😄

lordrip added a commit to lordrip/kaoto that referenced this issue Jan 22, 2024
@lordrip
feat(canvas): Show placeholder when there are no visible flows
f107399 
Currently, when the canvas is empty, being because there are no flows
defined or because there are but hidden, we see a gray area. This might
present an issue for the users, starting with a blank file in VSCode, as
it's not clear what's the first step to start working with the app.

This commit introduces a placeholder in case there are no flows or there
are but not visible

fix: KaotoIO#362
lordrip added a commit that referenced this issue Jan 22, 2024
@lordrip
feat(canvas): Show placeholder when there are no visible flows
fea6e99 
Currently, when the canvas is empty, being because there are no flows
defined or because there are but hidden, we see a gray area. This might
present an issue for the users, starting with a blank file in VSCode, as
it's not clear what's the first step to start working with the app.

This commit introduces a placeholder in case there are no flows or there
are but not visible

fix: #362
@github-project-automation github-project-automation bot moved this from In Review to Done in Kanban Board Jan 22, 2024
lordrip pushed a commit to lordrip/kaoto that referenced this issue Aug 30, 2024
@igarashitm
fix: Mapping lines missing inside for-each wrapping
8a08a75 
Fixes: KaotoIO#362
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lordrip lordrip

Labels
canvas/visualization Canvas-related issues enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Kanban Board
Archived in project
Milestone
2.0.0 TP1
Development

Successfully merging a pull request may close this issue.

feat(canvas): Show placeholder when there are no visible flows lordrip/kaoto
3 participants
@lhein @lordrip @bilalshaikh292