Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(canvas): Show placeholder when there are no visible flows #681

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

lordrip
Copy link
Member

@lordrip lordrip commented Jan 19, 2024

Context

Currently, when the canvas is empty, because there are no flows defined or because there are but hidden, we see a gray area. This might present an issue for the users, starting with a blank file in VSCode, as it's not clear what's the first step to start working with the app.

Changes

This commit introduces a placeholder in case there are no flows or there are but not visible

Before

image

After - No routes

image

After - No visible routes

image

fix: #362

@lordrip lordrip force-pushed the feat/no-routes-placeholder branch 2 times, most recently from 488fc42 to 1e18f2e Compare January 22, 2024 09:17
Copy link
Contributor

@lhein lhein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested functionality locally and it works fine

Currently, when the canvas is empty, being because there are no flows
defined or because there are but hidden, we see a gray area. This might
present an issue for the users, starting with a blank file in VSCode, as
it's not clear what's the first step to start working with the app.

This commit introduces a placeholder in case there are no flows or there
are but not visible

fix: KaotoIO#362
@lordrip lordrip force-pushed the feat/no-routes-placeholder branch from 1e18f2e to f107399 Compare January 22, 2024 09:32
@lordrip lordrip merged commit fea6e99 into KaotoIO:main Jan 22, 2024
10 checks passed
@lordrip lordrip deleted the feat/no-routes-placeholder branch January 22, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show a placeholder when there are no visible routes
2 participants