Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide test checking all components can display the property panel #449

Closed
4 of 5 tasks
apupier opened this issue Nov 29, 2023 · 1 comment · Fixed by #484, #497, #510 or #531
Closed
4 of 5 tasks

Provide test checking all components can display the property panel #449

apupier opened this issue Nov 29, 2023 · 1 comment · Fixed by #484, #497, #510 or #531
Assignees
@igarashitm
Labels
testing Unit or integration testing
Milestone
2.0.0 TP1

Comments

@apupier
Copy link
Member

apupier commented Nov 29, 2023 •
edited by igarashitm
Loading

Please describe the task that needs to be done

At least checking that there is no "Field no found in schema" errors which affected several different components in the past

see:

Tasks

  • components
  • kamelets
  • languages
  • dataformats
  • processors
@igarashitm
Copy link
Contributor

igarashitm commented Dec 1, 2023 •
edited
Loading

Since we now can use the real component catalog in Jest tests, it's possible to try rendering config form for all the components in the catalog and make sure it doesn't return an error. Would be nice to do the same for all processors/kamelets/languages/dataformats.

igarashitm added a commit to igarashitm/kaoto that referenced this issue Dec 2, 2023
@igarashitm
fix: Refactor component schema generation
5a41a4b 
* Moved component-catalog > JSON schema generation to the maven plugin
* Fixed array/object related issues in component schema (KaotoIO#448)
* Added default value handling for component schema
* Added an exhaustive test for rendering component configuration form (KaotoIO#449)
igarashitm added a commit to igarashitm/kaoto that referenced this issue Dec 2, 2023
@igarashitm
fix: Refactor component schema generation
ac4b0df 
* Moved component-catalog > JSON schema generation to the maven plugin
* Fixed array/object related issues in component schema (KaotoIO#448)
* Added default value handling for component schema
* Added an exhaustive test for rendering component configuration form (KaotoIO#449)
* Added `$comment` to hold the catalog `javaType`, supposed to be used for BeanReferenceField (KaotoIO#470)
igarashitm added a commit to igarashitm/kaoto that referenced this issue Dec 2, 2023
@igarashitm
fix: Refactor component schema generation
1aa3de2 
* Moved component-catalog > JSON schema generation to the maven plugin
* Fixed array/object related issues in component schema (KaotoIO#448)
* Added default value handling for component schema
* Added an exhaustive test for rendering component configuration form (KaotoIO#449)
* Added `$comment` to hold the catalog `javaType`, supposed to be used for BeanReferenceField (KaotoIO#470)
@igarashitm igarashitm mentioned this issue Dec 2, 2023
Merged
igarashitm added a commit to igarashitm/kaoto that referenced this issue Dec 2, 2023
@igarashitm
fix: Refactor component schema generation
b679e21 
* Moved component-catalog > JSON schema generation to the maven plugin
* Fixed array/object related issues in component schema (KaotoIO#448)
* Added default value handling for component schema
* Added an exhaustive test for rendering component configuration form (KaotoIO#449)
* Added `$comment` to hold the catalog `javaType`, supposed to be used for BeanReferenceField (KaotoIO#470)
igarashitm added a commit to igarashitm/kaoto that referenced this issue Dec 2, 2023
@igarashitm
fix: Refactor component schema generation
362a101 
* Moved component-catalog > JSON schema generation to the maven plugin
* Fixed array/object related issues in component schema (KaotoIO#448)
* Added default value handling for component schema
* Added an exhaustive test for rendering component configuration form (KaotoIO#449)
* Added `$comment` to hold the catalog `javaType`, supposed to be used for BeanReferenceField (KaotoIO#470)
@igarashitm igarashitm self-assigned this Dec 2, 2023
@igarashitm igarashitm moved this from New to In Progress in Kanban Board Dec 2, 2023
lordrip pushed a commit that referenced this issue Dec 4, 2023
@igarashitm @lordrip
fix: Refactor component schema generation
2c92564 
* Moved component-catalog > JSON schema generation to the maven plugin
* Fixed array/object related issues in component schema (#448)
* Added default value handling for component schema
* Added an exhaustive test for rendering component configuration form (#449)
* Added `$comment` to hold the catalog `javaType`, supposed to be used for BeanReferenceField (#470)
@lordrip lordrip linked a pull request Dec 4, 2023 that will close this issue
fix: Refactor component schema generation #484
Merged
igarashitm added a commit to igarashitm/kaoto that referenced this issue Dec 5, 2023
@igarashitm
fix: Refactor kamelet schema generation (KaotoIO#448)
3a8312d 
* Move kamelet schema generation to the maven plugin
* Change `binary` field type to `string`
* Add `enum`, `default` and `format` handling
* Add exhaustive test for rendering kamelet configuration (KaotoIO#449)
@igarashitm igarashitm mentioned this issue Dec 5, 2023
Merged
igarashitm added a commit to igarashitm/kaoto that referenced this issue Dec 5, 2023
@igarashitm
fix: Refactor kamelet schema generation (KaotoIO#448)
f4c8937 
* Move kamelet schema generation to the maven plugin
* Change `binary` field type to `string`
* Add `enum`, `default` and `format` handling
* Add exhaustive test for rendering kamelet configuration (KaotoIO#449)
lordrip pushed a commit that referenced this issue Dec 5, 2023
@igarashitm @lordrip
fix: Refactor kamelet schema generation (#448)
0c0f66f 
* Move kamelet schema generation to the maven plugin
* Change `binary` field type to `string`
* Add `enum`, `default` and `format` handling
* Add exhaustive test for rendering kamelet configuration (#449)
@igarashitm igarashitm added the testing Unit or integration testing label Dec 5, 2023
igarashitm added a commit to igarashitm/kaoto that referenced this issue Dec 5, 2023
@igarashitm
chore: Add exhaustive tests for rendering languages/dataformats confi…
2c66be0 
…g form (KaotoIO#449)

Also remove warning from uniforms about `additionalProperties` being passed down to the DOM
@igarashitm igarashitm mentioned this issue Dec 5, 2023
Merged
igarashitm added a commit to igarashitm/kaoto that referenced this issue Dec 5, 2023
@igarashitm
chore: Add exhaustive tests for rendering languages/dataformats confi…
0add02f 
…g form (KaotoIO#449)

Also remove warning from uniforms about `additionalProperties` being passed down to the DOM
igarashitm added a commit to igarashitm/kaoto that referenced this issue Dec 5, 2023
@igarashitm
chore: Add exhaustive tests for rendering languages/dataformats confi…
c4d2626 
…g form (KaotoIO#449)

Also remove warning from uniforms about `additionalProperties` being passed down to the DOM
igarashitm added a commit that referenced this issue Dec 5, 2023
@igarashitm @lhein
chore: Add exhaustive tests for rendering languages/dataformats confi…
1f5b42b 
…g form (#449) (#510)

Also remove warning from uniforms about `additionalProperties` being passed down to the DOM

Co-authored-by: Lars Heinemann <[email protected]>
This was linked to pull requests Dec 5, 2023
fix: Refactor kamelet schema generation (#448) #497
Merged
chore: Add exhaustive tests for rendering languages/dataformats confi… #510
Merged
igarashitm added a commit to igarashitm/kaoto that referenced this issue Dec 7, 2023
@igarashitm
fix: Refactor processors schema
9db6e9b 
* Extract processor JSON schema from main camelYamlDsl.json and put into pattern catalog as a `/propertiesSchema`
* Add control comment for complex parameters to `$comment` schema property, such as `class:<class name>`, `expression`, `dataformat`, `loadbalance` for those need special handling for configuration form rendering
* Remove oneOf/anyOf structures and extract the one needed for form rendering
* Added exhaustive rendering test for all processors

Fixes: KaotoIO#448
Fixes: KaotoIO#449
@igarashitm igarashitm mentioned this issue Dec 7, 2023
Merged
@igarashitm igarashitm moved this from In Progress to In Review in Kanban Board Dec 7, 2023
igarashitm added a commit that referenced this issue Dec 7, 2023
@igarashitm
fix: Refactor processors schema (#531)
e9d71c6 
* Extract processor JSON schema from main camelYamlDsl.json and put into pattern catalog as a `/propertiesSchema`
* Add control comment for complex parameters to `$comment` schema property, such as `class:<class name>`, `expression`, `dataformat`, `loadbalance` for those need special handling for configuration form rendering
* Remove oneOf/anyOf structures and extract the one needed for form rendering
* Added exhaustive rendering test for all processors

Fixes: #448
Fixes: #449
@github-project-automation github-project-automation bot moved this from In Review to Done in Kanban Board Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@igarashitm igarashitm

Labels
testing Unit or integration testing
Projects
Kanban Board
Archived in project
Milestone
2.0.0 TP1
2 participants
@igarashitm @apupier