Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Refactor processors schema #531

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

igarashitm
Copy link
Contributor

  • Extract processor JSON schema from main camelYamlDsl.json and put into pattern catalog as a /propertiesSchema
  • Add control comment for complex parameters to $comment schema property, such as class:<class name>, expression, dataformat, loadbalance for those need special handling for configuration form rendering
  • Remove oneOf/anyOf structures and extract the one needed for form rendering
  • Added exhaustive rendering test for all processors

Fixes: #448
Fixes: #449

* Extract processor JSON schema from main camelYamlDsl.json and put into pattern catalog as a `/propertiesSchema`
* Add control comment for complex parameters to `$comment` schema property, such as `class:<class name>`, `expression`, `dataformat`, `loadbalance` for those need special handling for configuration form rendering
* Remove oneOf/anyOf structures and extract the one needed for form rendering
* Added exhaustive rendering test for all processors

Fixes: KaotoIO#448
Fixes: KaotoIO#449
@igarashitm
Copy link
Contributor Author

2023-12-07.15-07-13.mp4

@igarashitm igarashitm merged commit e9d71c6 into KaotoIO:main Dec 7, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants