Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop down fields should contain an empty entry always #676

Closed
lhein opened this issue Jan 19, 2024 · 0 comments · Fixed by KaotoIO/uniforms-patternfly#61 or #679
Closed

drop down fields should contain an empty entry always #676

lhein opened this issue Jan 19, 2024 · 0 comments · Fixed by KaotoIO/uniforms-patternfly#61 or #679
Assignees
Labels
canvas/config-form Configuration form related issues ui/ux This issue is about improving the UI / UX
Milestone

Comments

@lhein
Copy link
Contributor

lhein commented Jan 19, 2024

The form select (drop down) we are currently using does not have a way to show that no value has been selected (we always select the first list item by default) and also no way to clean up a value.

Proposal:
Insert an entry to the drop down which represents an empty entry. We could label it as <empty>, Select... or simply leave it as empty string. If a parameter doesn't have a value set in the code we just select this empty entry. Also if the user selects this entry in the config form, then we should clear that parameter in the code.

Image

@lhein lhein converted this from a draft issue Jan 19, 2024
@lhein lhein added canvas/config-form Configuration form related issues ui/ux This issue is about improving the UI / UX labels Jan 19, 2024
@lhein lhein moved this from New to Todo in Kanban Board Jan 19, 2024
@lhein lhein added this to the 2.0.0 TP1 milestone Jan 19, 2024
lordrip added a commit to lordrip/uniforms-patternfly that referenced this issue Jan 19, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Kanban Board Jan 19, 2024
@lordrip lordrip reopened this Jan 19, 2024
@github-project-automation github-project-automation bot moved this from Done to Todo in Kanban Board Jan 19, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Kanban Board Jan 19, 2024
@lordrip lordrip reopened this Jan 19, 2024
@github-project-automation github-project-automation bot moved this from Done to Todo in Kanban Board Jan 19, 2024
@lordrip lordrip moved this from Todo to In Progress in Kanban Board Jan 19, 2024
@lordrip lordrip self-assigned this Jan 19, 2024
lordrip added a commit to lordrip/kaoto that referenced this issue Jan 19, 2024
Currently, there's no placeholder for the `SelectField`.

This commit updates `@kaoto-next/uniforms-patternfly` to version `^0.5.7` to be able
to import the typings for the `SelectField` component and create a
wrapper that sets a default placeholder.

fix: KaotoIO#676
lordrip added a commit to lordrip/kaoto that referenced this issue Jan 19, 2024
feat(form): Add a placeholder for Select fields

Currently, there's no placeholder for the `SelectField`.

This commit updates `@kaoto-next/uniforms-patternfly` to version `^0.5.7` to be able
to import the typings for the `SelectField` component and create a
wrapper that sets a default placeholder.

fix: KaotoIO#676
lordrip added a commit to lordrip/kaoto that referenced this issue Jan 19, 2024
Currently, there's no placeholder for the `SelectField`.

This commit updates `@kaoto-next/uniforms-patternfly` to version `^0.5.7` to be able
to import the typings for the `SelectField` component and create a
wrapper that sets a default placeholder.

fix: KaotoIO#676
lordrip added a commit that referenced this issue Jan 19, 2024
Currently, there's no placeholder for the `SelectField`.

This commit updates `@kaoto-next/uniforms-patternfly` to version `^0.5.7` to be able
to import the typings for the `SelectField` component and create a
wrapper that sets a default placeholder.

fix: #676
@github-project-automation github-project-automation bot moved this from In Progress to Done in Kanban Board Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
canvas/config-form Configuration form related issues ui/ux This issue is about improving the UI / UX
Projects
Archived in project
2 participants