feat(form): Add a placeholder for Select fields #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, there's no placeholder for the `SelectField`. This commit updates `@kaoto-next/uniforms-patternfly` to version `^0.5.7` to be able to import the typings for the `SelectField` component and create a wrapper that sets a default placeholder. fix: KaotoIO#676
lordrip
force-pushed
the
fix/placeholder-for-select
branch
from
d5060d0 to
a93b04e
Compare
lordrip
commented
Jan 19, 2024
|
|
||
| export const CustomSelectField: FunctionComponent<SelectFieldProps> = (props) => { | ||
| return <SelectField {...(props as SelectFieldProps)} placeholder="Please select an option..." />; | ||
| }; |
There was a problem hiding this comment.
wrapper for the CustomSelectField so we could add an additional property placeholder
tplevko
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there's no placeholder for the
SelectField.This commit updates
@kaoto-next/uniforms-patternflyto version^0.5.7to be able to import the typings for theSelectFieldcomponent and create a wrapper that sets a default placeholder.Before
After
fix: #676