Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nodes from the canvas #78

Closed
lordrip opened this issue Sep 4, 2023 · 1 comment · Fixed by #222 or #224
Closed

Remove nodes from the canvas #78

lordrip opened this issue Sep 4, 2023 · 1 comment · Fixed by #222 or #224
Assignees
@lordrip
Labels
canvas/visualization Canvas-related issues
Milestone
2.0.0 TP1

Comments

@lordrip
Copy link
Member

lordrip commented Sep 4, 2023 •
edited
Loading

Context

Currently, there's no mechanism to remove nodes from the canvas.

Goal

The goal for this issue is to provide a mechanism to remove nodes from the canvas, considering their position in it.

Open questions

  1. Should we aim to support placeholders when a step is removed?
@lordrip lordrip added the canvas/visualization Canvas-related issues label Sep 4, 2023
@lordrip lordrip added this to the 0.1.0 - Smart Connectors' MVP milestone Sep 4, 2023
@lhein lhein moved this to Backlog in Kanban Board Sep 21, 2023
@lhein lhein moved this from Backlog to Todo in Kanban Board Sep 21, 2023
@lordrip lordrip moved this from Todo to In Progress in Kanban Board Oct 16, 2023
@lordrip lordrip self-assigned this Oct 16, 2023
@lhein
Copy link
Contributor

lhein commented Oct 16, 2023

I wouldn't. For that there should be ways to insert between nodes.

@lordrip lordrip mentioned this issue Oct 16, 2023
Merged
lordrip added a commit to lordrip/kaoto that referenced this issue Oct 16, 2023
@lordrip
feat(viz): Remove nodes from the canvas
18cdae1 
This pull request adds the possibility to remove individual nodes from an integration, currently, it supports `Camel Routes` only

Notes:
* The `otherwise` property from the `choice` node remains due to a configuration in the `VisualizationNode` class, we'll tackle this in a separate pull request.
* Removing nodes from `Pipe` and `KameletBinding` is waiting until we receive the entire flow into the `PieVisualEntity` class

Fixes: KaotoIO#78
@lordrip lordrip moved this from In Progress to In Review in Kanban Board Oct 16, 2023
lordrip added a commit to lordrip/kaoto that referenced this issue Oct 16, 2023
@lordrip
feat(viz): Remove nodes from the canvas
e198293 
This pull request adds the possibility to remove individual nodes from an integration, currently, it supports `Camel Routes` only

Notes:
* The `otherwise` property from the `choice` node remains due to a configuration in the `VisualizationNode` class, we'll tackle this in a separate pull request.
* Removing nodes from `Pipe` and `KameletBinding` is waiting until we receive the entire flow into the `PieVisualEntity` class

Fixes: KaotoIO#78
lordrip added a commit to lordrip/kaoto that referenced this issue Oct 17, 2023
@lordrip
feat(viz): Remove nodes from the canvas
edb0b5c 
This pull request adds the possibility to remove individual nodes from an integration, currently, it supports `Camel Routes` only

Notes:
* The `otherwise` property from the `choice` node remains due to a configuration in the `VisualizationNode` class, we'll tackle this in a separate pull request.
* Removing nodes from `Pipe` and `KameletBinding` is waiting until we receive the entire flow into the `PieVisualEntity` class

Fixes: KaotoIO#78
lordrip added a commit to lordrip/kaoto that referenced this issue Oct 17, 2023
@lordrip
feat(viz): Remove nodes from the canvas
424215c 
This pull request adds the possibility to remove individual nodes from an integration, currently, it supports `Camel Routes` only

Notes:
* The `otherwise` property from the `choice` node remains due to a configuration in the `VisualizationNode` class, we'll tackle this in a separate pull request.
* Removing nodes from `Pipe` and `KameletBinding` is waiting until we receive the entire flow into the `PieVisualEntity` class

Fixes: KaotoIO#78
lordrip added a commit to lordrip/kaoto that referenced this issue Oct 17, 2023
@lordrip
feat(viz): Remove nodes from the canvas
c37bc37 
This pull request adds the possibility to remove individual nodes from an integration, currently, it supports `Camel Routes` only

Notes:
* The `otherwise` property from the `choice` node remains due to a configuration in the `VisualizationNode` class, we'll tackle this in a separate pull request.
* Removing nodes from `Pipe` and `KameletBinding` is waiting until we receive the entire flow into the `PieVisualEntity` class

Fixes: KaotoIO#78
lordrip added a commit to lordrip/kaoto that referenced this issue Oct 17, 2023
@lordrip
feat(viz): Remove nodes from the canvas
eebbcd6 
This pull request adds the possibility to remove individual nodes from an integration, currently, it supports `Camel Routes` only

Notes:
* The `otherwise` property from the `choice` node remains due to a configuration in the `VisualizationNode` class, we'll tackle this in a separate pull request.
* Removing nodes from `Pipe` and `KameletBinding` is waiting until we receive the entire flow into the `PieVisualEntity` class

Fixes: KaotoIO#78
@lordrip lordrip linked a pull request Oct 17, 2023 that will close this issue
chore(test): Cleanup tests logs #224
Merged
@github-project-automation github-project-automation bot moved this from In Review to Done in Kanban Board Oct 17, 2023
lordrip added a commit to lordrip/kaoto that referenced this issue Oct 17, 2023
@lordrip
feat(viz): Remove nodes from the canvas
a0245ee 
This pull request adds the possibility to remove individual nodes from an integration, currently, it supports `Camel Routes` only

Notes:
* The `otherwise` property from the `choice` node remains due to a configuration in the `VisualizationNode` class, we'll tackle this in a separate pull request.
* Removing nodes from `Pipe` and `KameletBinding` is waiting until we receive the entire flow into the `PieVisualEntity` class

Fixes: KaotoIO#78
@lordrip lordrip reopened this Oct 17, 2023
@github-project-automation github-project-automation bot moved this from Done to Todo in Kanban Board Oct 17, 2023
@lordrip lordrip moved this from Todo to In Review in Kanban Board Oct 17, 2023
lordrip added a commit that referenced this issue Oct 17, 2023
@lordrip
feat(viz): Remove nodes from the canvas
ee63d54 
This pull request adds the possibility to remove individual nodes from an integration, currently, it supports `Camel Routes` only

Notes:
* The `otherwise` property from the `choice` node remains due to a configuration in the `VisualizationNode` class, we'll tackle this in a separate pull request.
* Removing nodes from `Pipe` and `KameletBinding` is waiting until we receive the entire flow into the `PieVisualEntity` class

Fixes: #78
@github-project-automation github-project-automation bot moved this from In Review to Done in Kanban Board Oct 17, 2023
lordrip added a commit to lordrip/kaoto that referenced this issue Oct 24, 2023
@lordrip
feat(pipe): Enable remove steps for Pipes
57014e2 
fixes: KaotoIO#78
lordrip added a commit to lordrip/kaoto that referenced this issue Oct 24, 2023
@lordrip
feat(pipe): Enable remove steps for Pipes
249095e 
fixes: KaotoIO#78
lordrip added a commit that referenced this issue Oct 25, 2023
@lordrip
feat(pipe): Enable remove steps for Pipes
1478dae 
fixes: #78
@lhein lhein removed this from the Smart Connectors' MVP milestone Nov 2, 2023
@lhein lhein added this to the Feature Parity milestone Nov 2, 2023
lordrip pushed a commit to lordrip/kaoto that referenced this issue Aug 30, 2024
@igarashitm
checkpoint: transformation: added function catalog, added "edit trans…
de8dd1f 
…formation" mode (KaotoIO#78)
lordrip pushed a commit to lordrip/kaoto that referenced this issue Aug 30, 2024
@igarashitm
checkpoint: feed function catalog to FunctionSelector (KaotoIO#78)
df4f55b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lordrip lordrip

Labels
canvas/visualization Canvas-related issues
Projects
Kanban Board
Archived in project
Milestone
2.0.0 TP1
2 participants
@lhein @lordrip