Fix(1429): Typing full URI in Endpoint's name generates bad YAML #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivamG640
force-pushed
the
Fix_1429
branch
from
a90d684 to
d336509
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1467 +/- ##
=======================================
Coverage ? 68.64%
Complexity ? 25
=======================================
Files ? 269
Lines ? 7722
Branches ? 1537
=======================================
Hits ? 5301
Misses ? 2372
Partials ? 49 ☔ View full report in Codecov by Sentry. |
lordrip
reviewed
Sep 23, 2024
| @@ -109,7 +109,7 @@ export class CamelUriHelper { | |||
| queryString?.split('&').reduce((parameters, parameter) => { | |||
| if (parameter) { | |||
| const [key, stringValue] = parameter.split('='); | |||
| parameters[key] = getParsedValue(stringValue); | |||
| if (isDefined(stringValue) && stringValue !== '') parameters[key] = getParsedValue(stringValue); | |||
There was a problem hiding this comment.
Suggested change
| if (isDefined(stringValue) && stringValue !== '') parameters[key] = getParsedValue(stringValue); | |
| if (isDefined(stringValue) && stringValue !== '') { | |
| parameters[key] = getParsedValue(stringValue); | |
| } |
| Object.entries(CamelUriHelper.getParametersFromQueryString(queryUri)).reduce((parameters, parameter) => { | ||
| if (parameter) { | ||
| const [key, stringValue] = parameter; | ||
| if (catalogLookup.definition?.properties[key]) parameters[key] = stringValue; |
There was a problem hiding this comment.
Suggested change
| if (catalogLookup.definition?.properties[key]) parameters[key] = stringValue; | |
| if (catalogLookup.definition?.properties[key]) { | |
| parameters[key] = stringValue; | |
| } |
| } | ||
|
|
||
| return parameters; | ||
| }, {} as ParsedParameters) ?? {}; |
There was a problem hiding this comment.
Suggested change
| }, {} as ParsedParameters) ?? {}; | |
| }, {} as ParsedParameters); |
|
|
Created new PR : #1493 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1429