chore: Use string key instead of number for modal action key (#1537) #1569
Conversation
| @@ -583,21 +583,6 @@ exports[`CustomAutoFields renders \`AutoFields\` for common fields 1`] = ` | |||
| value="" | |||
| /> | |||
| </span> | |||
| <div | |||
There was a problem hiding this comment.
Not sure why, this also fails with upstream main for me and need yarn test -u to fix
There was a problem hiding this comment.
ugh and workflow wants to add it back... not sure what's going on...
There was a problem hiding this comment.
reverted the snapshot change to let the workflow pass
There was a problem hiding this comment.
How do you execute the test? a single one or all of them? sometimes the IDs are generated in sequence, so if you execute a single test, the ID is 1, but if you execute alongside others, maybe it is 4 instead.
There was a problem hiding this comment.
I'm using yarn workspaces foreach --all --topological-dev run test and it fails for me with upstream main, stating that this div should be removed.
[@kaoto/kaoto]: FAIL src/components/Form/CustomAutoFields.test.tsx
[@kaoto/kaoto]: ● CustomAutoFields › renders `AutoFields` for common fields
[@kaoto/kaoto]:
[@kaoto/kaoto]: expect(received).toMatchSnapshot()
[@kaoto/kaoto]:
[@kaoto/kaoto]: Snapshot name: `CustomAutoFields renders \`AutoFields\` for common fields 1`
[@kaoto/kaoto]:
[@kaoto/kaoto]: - Snapshot - 15
[@kaoto/kaoto]: + Received + 0
[@kaoto/kaoto]:
[@kaoto/kaoto]: @@ -500,25 +500,10 @@
[@kaoto/kaoto]: step="1"
[@kaoto/kaoto]: type="number"
[@kaoto/kaoto]: value=""
[@kaoto/kaoto]: />
[@kaoto/kaoto]: </span>
[@kaoto/kaoto]: - <div
[@kaoto/kaoto]: - class="pf-v5-c-form__helper-text"
[@kaoto/kaoto]: - >
[@kaoto/kaoto]: - <div
[@kaoto/kaoto]: - class="pf-v5-c-helper-text"
[@kaoto/kaoto]: - >
[@kaoto/kaoto]: - <div
[@kaoto/kaoto]: - class="pf-v5-c-helper-text__item"
[@kaoto/kaoto]: - >
[@kaoto/kaoto]: - <span
[@kaoto/kaoto]: - class="pf-v5-c-helper-text__item-text"
[@kaoto/kaoto]: - />
[@kaoto/kaoto]: - </div>
[@kaoto/kaoto]: - </div>
[@kaoto/kaoto]: - </div>
[@kaoto/kaoto]: </div>
[@kaoto/kaoto]: </div>
[@kaoto/kaoto]: <div
[@kaoto/kaoto]: class="pf-v5-c-expandable-section"
[@kaoto/kaoto]: >
[@kaoto/kaoto]:
[@kaoto/kaoto]: 20 | });
[@kaoto/kaoto]: 21 |
[@kaoto/kaoto]: > 22 | expect(wrapper?.asFragment()).toMatchSnapshot();
[@kaoto/kaoto]: | ^
[@kaoto/kaoto]: 23 | });
[@kaoto/kaoto]: 24 |
[@kaoto/kaoto]: 25 | it('render `NoFieldFound` when there are no fields', () => {
[@kaoto/kaoto]:
[@kaoto/kaoto]: at Object.toMatchSnapshot (src/components/Form/CustomAutoFields.test.tsx:22:35)
There was a problem hiding this comment.
But anyway this PR is already adjusted to pass GH workflows although it fails with above locally for me.
igarashitm
force-pushed
the
modal-action-string-key
branch
from
16de62a to
21803d0
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1569 +/- ##
=======================================
Coverage ? 80.01%
Complexity ? 272
=======================================
Files ? 276
Lines ? 7839
Branches ? 1523
=======================================
Hits ? 6272
Misses ? 1458
Partials ? 109 ☔ View full report in Codecov by Sentry. |
No description provided.