feat(IVizNode): Get All Visualization nodes #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A frequent use case for the Canvas is to identify nodes, unfortunately, there's no easy way to find nodes using a predicate.
This commit allows finding nodes given a predicate or retrieving all nodes if no predicate has been provided.
* How to use?
```typescript
// First we obtain the `VisualizationController`
const controller = useVisualizationController();
// Second, we define a predicate
const predicate = (vizNode: IVisualizationNode) => {
return vizNode.getComponentSchema()?.definition?.disabled;
};
// Lastly, we use the `getVisualizationNodesFromGraph` function to find the nodes
const vizNodes = getVisualizationNodesFromGraph(visualizationController.getGraph(), predicate);
```
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1573 +/- ##
=======================================
Coverage ? 79.96%
Complexity ? 272
=======================================
Files ? 277
Lines ? 7880
Branches ? 1546
=======================================
Hits ? 6301
Misses ? 1470
Partials ? 109 ☔ View full report in Codecov by Sentry. |
igarashitm
approved these changes
Oct 14, 2024
tplevko
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
A frequent use case for the Canvas is to identify nodes, unfortunately, there's no easy way to find nodes using a predicate.
Changes
This PR allows finding nodes given a predicate or retrieving all nodes if no predicate has been provided.
How to use?
Prerequisite of: #1574