Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Canvas): Extract item enable all steps #1574

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

lordrip
Copy link
Member

@lordrip lordrip commented Oct 14, 2024

Context

This PR extracts the logic to reenable all disabled steps in the Canvas. In addition to that, it also adds missing tests.

Note

This PR should be merged after #1573

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@d985f82). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...sualization/Custom/ContextMenu/ItemDisableStep.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1574   +/-   ##
=======================================
  Coverage        ?   80.09%           
  Complexity      ?      272           
=======================================
  Files           ?      278           
  Lines           ?     7882           
  Branches        ?     1542           
=======================================
  Hits            ?     6313           
  Misses          ?     1460           
  Partials        ?      109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lordrip lordrip force-pushed the chore/extract-item-enable-all-steps branch from 2541002 to 90c5806 Compare October 15, 2024 08:19
@lordrip lordrip requested a review from ibek October 15, 2024 08:19
Copy link

sonarcloud bot commented Oct 15, 2024

@lordrip lordrip marked this pull request as ready for review October 15, 2024 08:20
@lordrip lordrip merged commit 3ec247d into KaotoIO:main Oct 15, 2024
12 of 13 checks passed
@lordrip lordrip deleted the chore/extract-item-enable-all-steps branch October 15, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants