Adding more logging for the initial generate setup #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecasual
requested review from
benjaminjkraft,
csilvers,
dnerdy and
StevenACoffman
as code owners
benjaminjkraft
approved these changes
Nov 21, 2022
There was a problem hiding this comment.
Seems reasonable! Ideally we'd have a field for this so we can print it nicely and consistently, I'll add a note to #118.
benjaminjkraft
requested changes
Nov 21, 2022
|
I am not sure how to do that apologies. Can you help? Thanks! Also, really enjoying this project as I learn it. There was a few other places I was going to add some documentation for things that I have ran into. I will probably update that as well if that is acceptable for this project :) |
6 tasks
|
Hi @thecasual ! I made a PR against your repository that should fix it for you! |
6 tasks
StevenACoffman
added a commit
that referenced
this pull request
Dec 22, 2022
This is just a tweak to #239 to update the snapshots. I have: - [X] Written a clear PR title and description (above) - [X] Signed the [Khan Academy CLA](https://www.khanacademy.org/r/cla) - [X] Added tests covering my changes, if applicable - [X] Included a link to the issue fixed, if applicable - [X] Included documentation, for new features - [ ] Added an entry to the changelog Signed-off-by: Steve Coffman <[email protected]> Co-authored-by: Sam Wallace <[email protected]>
|
Closed by #246 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have: