Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR 239 update: Adding more logging for the initial generate setup #246

Merged
merged 2 commits into from
Dec 22, 2022
Merged

PR 239 update: Adding more logging for the initial generate setup #246

merged 2 commits into from
Dec 22, 2022

Conversation

StevenACoffman
Copy link
Member

@StevenACoffman StevenACoffman commented Dec 22, 2022 •
edited
Loading

This is just a tweak to #239 to update the snapshots.
I have:

  • Written a clear PR title and description (above)
  • Signed the Khan Academy CLA
  • Added tests covering my changes, if applicable
  • Included a link to the issue fixed, if applicable
  • Included documentation, for new features
  • Added an entry to the changelog

csilvers
csilvers approved these changes Dec 22, 2022
View reviewed changes
Copy link
Member

@csilvers csilvers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good by me. I just hope we remember to update these example line-numbers if example/genqlient.yaml ever changes!

@StevenACoffman StevenACoffman merged commit 596c33f into Khan:main Dec 22, 2022
@StevenACoffman StevenACoffman mentioned this pull request Dec 22, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csilvers csilvers csilvers approved these changes

@benjaminjkraft benjaminjkraft Awaiting requested review from benjaminjkraft benjaminjkraft is a code owner

@dnerdy dnerdy Awaiting requested review from dnerdy dnerdy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StevenACoffman @csilvers @thecasual