Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Universal Windows Platform support #414

Merged
merged 5 commits into from
May 18, 2021

Conversation

atteneder
Copy link
Contributor

Had to make OpenGL upload functions optional to get libktx to build for UWP.

@MarkCallow
Copy link
Collaborator

Is this actually necessary? glloader.c doesn't attempt to do anything unless the application calls the function and all it needs for building are the header files included in other_include. If the platform doesn't support OpenGL then the app won't be able to create a GL context which is a prerequisite to calling the ktxTexture[12]_GLUpload. Of course it will save a little space if it's not there and will avoid confusion.

@atteneder
Copy link
Contributor Author

Can't remember exactly, but when creating this fix initially (against beta 6 iirc) I think it was necessary. Let me check.

Since we're at it: are there plans to implement similar upload functionality for further graphic APIs (Metal, Direct3D)?

@atteneder
Copy link
Contributor Author

Sorry, I should've tested more thoroughly before submitting the PR.

I tried to configure/build but got lots of errors liket this one. Looks like the default compiler configuration for this platform is more strict. You mentioned you're working on level 4 warning stuff, so I'll wait until that landed before I continue.

In case you want to try out UWP/ARM64, here's how I configured it:

cmake . -G "Visual Studio 16 2019" -A ARM64 -B build_uwp_arm64 -DCMAKE_SYSTEM_NAME:String=WindowsStore -DCMAKE_SYSTEM_VERSION:String="10.0" -DBASISU_SUPPORT_SSE=OFF

Thanks

@MarkCallow
Copy link
Collaborator

Since we're at it: are there plans to implement similar upload functionality for further graphic APIs (Metal, Direct3D)?

I have no plan but I'd happily accept contributions.

Sorry, I should've tested more thoroughly before submitting the PR.

It's building now without warnings. What did you do?

@MarkCallow
Copy link
Collaborator

I've landed PR #418 raising the warning level and fixing all the warnings. Please rebase your PRs.

@MarkCallow
Copy link
Collaborator

Please add how to build for Windows Store to BUILDING.md. Then I'll merge this.

@atteneder
Copy link
Contributor Author

I added build instructions and fixed the cpu detection when cross compiling to UWP ARM/ARM64 (so that SSE is not mistakenly enabled)

@MarkCallow
Copy link
Collaborator

Please fix the conflicts. They're probably because I just landed the Android build PR.

@MarkCallow MarkCallow merged commit 38f6394 into KhronosGroup:master May 18, 2021
@atteneder atteneder deleted the no_gl_funcs branch June 10, 2021 17:22
KaperD pushed a commit to KaperD/KTX-Software that referenced this pull request Feb 21, 2024
KaperD pushed a commit to KaperD/KTX-Software that referenced this pull request Feb 22, 2024
KaperD pushed a commit to KaperD/KTX-Software that referenced this pull request Feb 22, 2024
KaperD pushed a commit to KaperD/KTX-Software that referenced this pull request Feb 22, 2024
KaperD pushed a commit to KaperD/KTX-Software that referenced this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants