Raise warning levels to /W4 & -Wall -Wextra #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually this selectively turns off warnings for the basisu & gtest code.
Actually this selectively turns off warnings for the basisu & gtest code.
…/KTX-Software into raise_warning_level
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 21, 2024
Several warnings are disabled for the basisu files and one for the gtest files. Other changes included here: * Add a couple of bad ktx2 files for testing ktx2check * Updates the Travis Build to Xcode 12.4 along with using xcpretty to shorten the log so as to remain within Travis-CI limits. * Fixes some warnings in the .travis.yml file.
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
Several warnings are disabled for the basisu files and one for the gtest files. Other changes included here: * Add a couple of bad ktx2 files for testing ktx2check * Updates the Travis Build to Xcode 12.4 along with using xcpretty to shorten the log so as to remain within Travis-CI limits. * Fixes some warnings in the .travis.yml file.
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
Several warnings are disabled for the basisu files and one for the gtest files. Other changes included here: * Add a couple of bad ktx2 files for testing ktx2check * Updates the Travis Build to Xcode 12.4 along with using xcpretty to shorten the log so as to remain within Travis-CI limits. * Fixes some warnings in the .travis.yml file.
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
Several warnings are disabled for the basisu files and one for the gtest files. Other changes included here: * Add a couple of bad ktx2 files for testing ktx2check * Updates the Travis Build to Xcode 12.4 along with using xcpretty to shorten the log so as to remain within Travis-CI limits. * Fixes some warnings in the .travis.yml file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updates Travis CI from Xcode 11.4 to 12.4 & shortens Xcode build logs with xcpretty to fit within Travis limits. The 12.4 logs are enough longer than 11.4 to trigger the automatic kill at 4MB.
There are still 2 warnings in the VS2017 build but it is not worth uglifying the code to fix them as they warn of some usage being an extension. It's standard in VS2019, Clang and GCC and the code obviously works in VS2017.