Fix broken API reference links to the Project Reactor Javadoc #4111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkhalanskyjb
force-pushed
the
dk-fix-broken-react-links
branch
from
8e1c76d to
70dc57a
Compare
qwwdfsad
reviewed
Apr 23, 2024
| @@ -14,6 +14,7 @@ lincheck_version=2.18.1 | |||
| dokka_version=1.9.20 | |||
| byte_buddy_version=1.10.9 | |||
| reactor_version=3.4.1 | |||
| reactor_docs_version=3.4.5 | |||
There was a problem hiding this comment.
Shouldn't we update reactor version instead?
There was a problem hiding this comment.
I thought we were trying to depend on the earliest version possible, so as not to force the users to upgrade to the new Reactor just because of our integration. There are some repositories with 3.3 and 3.4 versions of Reactor mentioned as dependencies.
qwwdfsad
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See reactor/reactor-core#3794