Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken API reference links to the Project Reactor Javadoc #4111

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Fix broken API reference links to the Project Reactor Javadoc #4111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ lincheck_version=2.18.1
dokka_version=1.9.20
byte_buddy_version=1.10.9
reactor_version=3.4.1
reactor_docs_version=3.4.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we update reactor version instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we were trying to depend on the earliest version possible, so as not to force the users to upgrade to the new Reactor just because of our integration. There are some repositories with 3.3 and 3.4 versions of Reactor mentioned as dependencies.

reactive_streams_version=1.0.3
rxjava2_version=2.2.8
rxjava3_version=3.0.2
Expand Down
8 changes: 4 additions & 4 deletions reactive/kotlinx-coroutines-reactor/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,8 @@ plugins {
id("org.jetbrains.kotlinx.kover")
}

val reactorVersion = version("reactor")

dependencies {
api("io.projectreactor:reactor-core:$reactorVersion")
api("io.projectreactor:reactor-core:${version("reactor")}")
api(project(":kotlinx-coroutines-reactive"))
}

Expand All @@ -27,8 +25,10 @@ tasks {
}
}

// the version of the docs can be different from the version of the Reactor
// library itself: https://github.com/reactor/reactor-core/issues/3794
externalDocumentationLink(
url = "https://projectreactor.io/docs/core/$reactorVersion/api/"
url = "https://projectreactor.io/docs/core/${version("reactor_docs")}/api/"
)


Expand Down