Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GeoMechanicsApplication] Migrating the ApplyScalarConstraintTableProcess from Python to C++ #11581

Closed
indigocoral opened this issue Sep 20, 2023 · 0 comments
Assignees
Labels
GeoMechanics Issues related to the GeoMechanicsApplication

Comments

@indigocoral
Copy link
Contributor

indigocoral commented Sep 20, 2023

Note for reviewers: after renaming the associated branch, I was unable to update the link under "Development". Therefore, you are kindly forwarded to PR #11669.

As a developer in the Kratos core, I would like to create and instantiate water pressure processes from the project parameters, such that I can use them in the Settlement Workflow.

Background

This issue aims to implement the earlier created process factory (see #11556 for more details) into the KratosGeoSettlement class, to create all necessary processes, except ApplyScalarConstraintTableProcess, for the settlement workflow.
In order to be able to use ApplyScalarConstraintTableProcess in the dgeosettlement.cpp for Settlement workflow, the logic in the python should be migrated to C++.

Acceptance Criteria

Given the developer has water pressure processes defined in the ProjectParameters.json file
When the developer runs the settlement stage (using the KratosGeoSettlement::RunStage function)
Then the processes associated with water pressures in the settlement workflow are instantiated and ready for further use in the workflow.

Given the developer/user has processes defined which are not in the list of expected processes.
When the developer/user runs the settlement stage (using the KratosGeoSettlement::RunStage function)
Then these non-defined processes raise an error message "Unknown fluid_pressure_type: (name of the process), the calculation is then aborted" and stops.

@indigocoral indigocoral converted this from a draft issue Sep 20, 2023
@indigocoral indigocoral self-assigned this Sep 20, 2023
@indigocoral indigocoral added the GeoMechanics Issues related to the GeoMechanicsApplication label Sep 20, 2023
@indigocoral indigocoral moved this from 📋 Sprint Backlog to 👷 In Progress in Kratos Product Backlog Sep 21, 2023
@mcgicjn2 mcgicjn2 moved this from 👷 In Progress to 👀 In Review in Kratos Product Backlog Oct 6, 2023
@avdg81 avdg81 closed this as completed Oct 9, 2023
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in Kratos Product Backlog Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GeoMechanics Issues related to the GeoMechanicsApplication
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants