Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GeoMechanicsApplication] Add necessary processes to the Settlement workflow #11576

Closed
rfaasse opened this issue Sep 19, 2023 · 0 comments · Fixed by #11591
Closed

[GeoMechanicsApplication] Add necessary processes to the Settlement workflow #11576

rfaasse opened this issue Sep 19, 2023 · 0 comments · Fixed by #11591
Assignees

Comments

@rfaasse
Copy link
Contributor

rfaasse commented Sep 19, 2023

As a developer in the Kratos core, I would like to create and instantiate processes from the project parameters, such that I can use them in the Settlement Workflow.

Background

This issue aims to implement the earlier created process factory (see #11556 for more details) into the KratosGeoSettlement class, to create all necessary processes, except ApplyScalarConstraintTableProcess, for the settlement workflow. This includes the following processes and will instantiate them to make them available for the next part of the workflow:

  1. ApplyVectorConstraintTableProcess
  2. SetParameterFieldProcess
  3. ApplyExcavationProcess
  4. ApplyK0ProcedureProcess

However for implementing the before mentioned ApplyScalarConstraintTableProcess (needed for the initial hydrostatic water pressure and pressure boundary condition), some more work needs to be done to move logic currently present in the python script to a c++ class, which is picked up in #11581

Acceptance Criteria

Given the developer has processes defined in the ProjectParameters.json file
When the developer runs the settlement stage (using the KratosGeoSettlement::RunStage function)
Then the processes associated to the settlement workflow are instantiated and ready for further use in the workflow

Given the developer/user has processes defined which are not in the list of expected processes.
When the developer/user runs the settlement stage (using the KratosGeoSettlement::RunStage function)
Then these non-relevant processes raises an error message "Unexpected process (name of the process), calculation is aborted" and stops the calculation.

@rfaasse rfaasse converted this from a draft issue Sep 19, 2023
@rfaasse rfaasse self-assigned this Sep 19, 2023
@rfaasse rfaasse changed the title Add necessary processes to the Settlement workflow [GeoMechanicsApplication] Add necessary processes to the Settlement workflow Sep 20, 2023
@rfaasse rfaasse moved this from 👷 In Progress to 👀 In Review in Kratos Product Backlog Sep 25, 2023
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in Kratos Product Backlog Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant