Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GeoMechanicsApplication] Add process factory to settlement workflow #11591

Merged
merged 23 commits into from
Sep 27, 2023
Merged

[GeoMechanicsApplication] Add process factory to settlement workflow #11591

merged 23 commits into from
Sep 27, 2023

Conversation

rfaasse
Copy link
Contributor

@rfaasse rfaasse commented Sep 22, 2023 •
edited
Loading

📝 Description
In this PR, the functionality is added to create and instantiate processes from the project parameters in the KratosGeoSettlement class, such that they can be used in the next steps of the settlement workflow.

🆕 Changelog

  • Added functionality to read project parameters to instantiate the relevant processes
  • Added the process factory to the settlement workflow
  • Added cpp unit tests for all newly added functionality

rfaasse and others added 14 commits September 14, 2023 09:10
@rfaasse
Merge branch 'master' into maas
f82d240
@rfaasse
Initial addition of processfactory to settlement workflow
a752a92
@rfaasse
Added version of a UT that checks if initialization throws
d4aae3b
@rfaasse
Progress on dgeosettlement unit test
e47ebf8
@rfaasse
added first version of ProcessNameParser
4107576
@rfaasse
Added functionality + UTs for retrieving process info
e45aaa0
@rfaasse
Fix build
1a388a9
@rfaasse
Merge branch 'master' into geo/add-process-factory-to-settlement
9fc6f8a
@rfaasse
Added ProjectInfoParser to GeoSettlement workflow + rename/interface …
816ed51 
…extraction
@rfaasse
Revert rename
3a0d520
@rfaasse
Retrieved processes from json string and prepared vector of refs for …
b721234 
…the timeloop executor
@rfaasse
added stub functionality to stub process info parser
347214c
@rfaasse
Minor renaming and formatting changes
206307e
@rfaasse
Clean up + fixing SonarQube issues
fd46be1
@rfaasse rfaasse requested a review from avdg81 September 22, 2023 12:23
@rfaasse rfaasse changed the title Add process factory to settlement [GeoMechanicsApplication] Add process factory to settlement Sep 22, 2023
avdg81
avdg81 reviewed Sep 25, 2023
View reviewed changes
applications/GeoMechanicsApplication/custom_utilities/json_process_info_parser.cpp Outdated Show resolved Hide resolved
applications/GeoMechanicsApplication/custom_workflows/dgeosettlement.cpp Outdated Show resolved Hide resolved
applications/GeoMechanicsApplication/custom_workflows/dgeosettlement.cpp Outdated Show resolved Hide resolved
applications/GeoMechanicsApplication/custom_workflows/dgeosettlement.cpp Outdated Show resolved Hide resolved
applications/GeoMechanicsApplication/custom_utilities/process_parameters.h Outdated Show resolved Hide resolved
applications/GeoMechanicsApplication/tests/cpp_tests/stub_time_loop_executor.h Show resolved Hide resolved
applications/GeoMechanicsApplication/tests/cpp_tests/stub_time_loop_executor.h Outdated Show resolved Hide resolved
applications/GeoMechanicsApplication/tests/cpp_tests/stub_time_loop_executor.cpp Outdated Show resolved Hide resolved
applications/GeoMechanicsApplication/tests/cpp_tests/test_process_info_parser.cpp Outdated Show resolved Hide resolved
applications/GeoMechanicsApplication/tests/cpp_tests/test_process_info_parser.cpp Outdated Show resolved Hide resolved
@rfaasse rfaasse requested a review from avdg81 September 26, 2023 11:08
@rfaasse rfaasse linked an issue Sep 26, 2023 that may be closed by this pull request
[GeoMechanicsApplication] Add necessary processes to the Settlement workflow #11576
Closed
@rfaasse rfaasse changed the title [GeoMechanicsApplication] Add process factory to settlement [GeoMechanicsApplication] Add process factory to settlement workflow Sep 26, 2023
avdg81
avdg81 reviewed Sep 26, 2023
View reviewed changes
Copy link
Contributor

@avdg81 avdg81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a few minor comments.

applications/GeoMechanicsApplication/custom_utilities/json_process_info_parser.cpp Outdated Show resolved Hide resolved
applications/GeoMechanicsApplication/custom_workflows/dgeosettlement.cpp Outdated Show resolved Hide resolved
applications/GeoMechanicsApplication/custom_utilities/process_factory.cpp Outdated Show resolved Hide resolved
applications/GeoMechanicsApplication/custom_workflows/dgeosettlement.cpp Outdated Show resolved Hide resolved
@rfaasse rfaasse requested a review from avdg81 September 26, 2023 14:25
avdg81
avdg81 previously approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@avdg81 avdg81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

avdg81
avdg81 approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@avdg81 avdg81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these SonarQube issues.

@rfaasse rfaasse merged commit f557260 into master Sep 27, 2023
@rfaasse rfaasse deleted the geo/add-process-factory-to-settlement branch September 27, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avdg81 avdg81 avdg81 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[GeoMechanicsApplication] Add necessary processes to the Settlement workflow
2 participants
@rfaasse @avdg81