[Core][Fluid][PotentialFlow] Move PENALTY_COEFFICIENT variable to KratosCore #12117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddiezrod
approved these changes
Feb 28, 2024
marcnunezc
approved these changes
Feb 28, 2024
rubenzorrilla
deleted the
core/move-penalty-coefficient-to-kratos-core
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
In this PR I'm moving the
PENALTY_COEFFICIENTvariable from theFluidDynamicsApplicationto theKratosCore. Note that this is suitable for any unfitted technique, which can implement any physics (i.e., can be used by any application).@frawahl @NickNick9 you'd eventually need this for your ongoing / upcoming developments.