Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FastPR][ConvDiff] Remove PENALTY_DIRICHLET by PENALTY_COEFFICIENT #12121

Merged
merged 1 commit into from
Feb 29, 2024
Merged

[FastPR][ConvDiff] Remove PENALTY_DIRICHLET by PENALTY_COEFFICIENT #12121

merged 1 commit into from
Feb 29, 2024

Conversation

rubenzorrilla
Copy link
Member

📝 Description
Followup of #12117. Aiming at unifying the unfitted elements as much as possible, this PR removes the PENALTY_DIRICHLET variable in the ConvectionDiffusionApplication in favor of the PENALTY_COEFFICIENT one in KratosCore.

@rubenzorrilla rubenzorrilla added Duplicate Applications FastPR This Pr is simple and / or has been already tested and the revision should be fast labels Feb 28, 2024
@rubenzorrilla rubenzorrilla self-assigned this Feb 28, 2024
@rubenzorrilla rubenzorrilla requested a review from a team as a code owner February 28, 2024 18:01
ddiezrod
ddiezrod approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@ddiezrod ddiezrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rubenzorrilla rubenzorrilla mentioned this pull request Feb 29, 2024
Merged
frawahl
frawahl approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@frawahl frawahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rubenzorrilla rubenzorrilla merged commit 502e2b2 into master Feb 29, 2024
15 of 17 checks passed
@rubenzorrilla rubenzorrilla deleted the convdiff/remove-duplicated-penalty-variable branch February 29, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddiezrod ddiezrod ddiezrod approved these changes

@frawahl frawahl frawahl approved these changes

Assignees

@rubenzorrilla rubenzorrilla

Labels
Applications Duplicate FastPR This Pr is simple and / or has been already tested and the revision should be fast
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rubenzorrilla @ddiezrod @frawahl