[GeoMechanicsApplication] Extract pre-calculated lists for strain vectors and (determinants of) deformation gradients #12363

rfaasse · 2024-05-08T14:22:02Z

📝 Description
This PR starts to extract element-wide lists (all integration point at the same time) for:

The deformation gradients
The determinants of the integration coefficients
The strain vectors

Although we add some duplication, which later we would like to remove when compressing diff-order/normal upw element into one, we start seeing here already we can start removing quite a bit of code because of this restructuring.

…Strain` to return a vector and takes relevant inputs instead of variables

…rn a vector and takes relevant inputs instead of variables

…) to return a vector instead of using the ElementVariables

…rmation gradient, instead of getting it from ElementVariables

…deformation gradient, instead of getting it from ElementVariables

…train-vector-calculations

…trix, displacements and UseHenckyStrainFlag instead of using ElementVariables

…b matrix, displacements and UseHenckyStrainFlag instead of using ElementVariables

…train-vector-calculations

…sed it to calculate lists up front

…element, and used it to calculate lists up front

…culate lists up front

…train-and-F-lists

…minants and strain vectors to U_Pw_small_strain_element.hpp

markelov208

Richard, thank you for the next step. The code is getting to be shorter and clear. My comments about movement of some functions to utilities. After changes made they look very similar for different elements.

applications/GeoMechanicsApplication/custom_elements/U_Pw_small_strain_element.cpp

applications/GeoMechanicsApplication/custom_elements/small_strain_U_Pw_diff_order_element.cpp

WPK4FEM

Hi Richard,
After you explained the capture lists to me, most is clear.
Now that this has taken the strain, F and detF computations out of the integration point loops, I expect that Variables.B can be removed. Variables.B only has a purpose for the strain computation and that has be handled already.
Regards, Wijtze Pieter

WPK4FEM · 2024-05-13T09:23:11Z

applications/GeoMechanicsApplication/custom_elements/U_Pw_small_strain_element.cpp

+    const auto determinants_of_deformation_gradients =
+        CalculateDeterminantsOfDeformationGradients(deformation_gradients);
+    const auto strain_vectors = CalculateStrains(
+        deformation_gradients, b_matrices, Variables.DisplacementVector, Variables.UseHenckyStrain);

    // Loop over integration points
    for (unsigned int GPoint = 0; GPoint < NumGPoints; ++GPoint) {
        this->CalculateKinematics(Variables, GPoint);
        Variables.B = b_matrices[GPoint];

        // Compute infinitesimal strain


These comments are now not true anymore.

True, I could still remove them in this PR, or wait for the next, what do you prefer?

WPK4FEM · 2024-05-13T09:32:26Z

applications/GeoMechanicsApplication/custom_elements/U_Pw_small_strain_element.cpp

@@ -1568,6 +1571,22 @@ Vector UPwSmallStrainElement<TDim, TNumNodes>::CalculateStrain(const Matrix& rDe
                           : this->CalculateCauchyStrain(rB, rDisplacements);
 }

+template <unsigned int TDim, unsigned int TNumNodes>
+std::vector<Vector> UPwSmallStrainElement<TDim, TNumNodes>::CalculateStrains(const std::vector<Matrix>& rDeformationGradients,


I wondered if only the s of strains would be enough to indicate that this is for all integration points ( e.g. for all components. ) CalculateStrain already is for all components in 1 integration point.

I don't know a better name, they soon become very long.

I'm also not too sure about better naming unfortunately

On second thought, would CalculateStrainVectors be a more suitable name?

WPK4FEM · 2024-05-13T09:51:53Z

applications/GeoMechanicsApplication/custom_elements/small_strain_U_Pw_diff_order_element.cpp

@@ -547,11 +556,9 @@ void SmallStrainUPwDiffOrderElement::FinalizeSolutionStep(const ProcessInfo& rCu
        Variables.B = b_matrices[GPoint];


Now that strains are computed outside the loop, I expect that the B matrices can be removed from Variables already.

Just to document what we already discussed: it is still used in the calculation of the stiffness matrix, so it unfortunately cannot be removed yet:

template <unsigned int TDim, unsigned int TNumNodes> void UPwSmallStrainElement<TDim, TNumNodes>::CalculateAndAddStiffnessMatrix(MatrixType& rLeftHandSideMatrix, ElementVariables& rVariables) { KRATOS_TRY noalias(rVariables.UVoigtMatrix) = prod(trans(rVariables.B), rVariables.ConstitutiveMatrix); noalias(rVariables.UUMatrix) = prod(rVariables.UVoigtMatrix, rVariables.B) * rVariables.IntegrationCoefficient; // Distribute stiffness block matrix into the elemental matrix GeoElementUtilities::AssembleUUBlockMatrix(rLeftHandSideMatrix, rVariables.UUMatrix); KRATOS_CATCH("") }

…train-and-F-lists

…for calculating the determinants of a list of matrices

…er elements.

…train-and-F-lists

markelov208

Richard, thank you for the quick changes.

rfaasse · 2024-05-13T14:24:10Z

applications/GeoMechanicsApplication/custom_elements/U_Pw_small_strain_element.cpp

-            Variables.StrainVector = this->CalculateStrain(
-                Variables.F, Variables.B, Variables.DisplacementVector, Variables.UseHenckyStrain);
-            permeability_update_factors.push_back(this->CalculatePermeabilityUpdateFactor(Variables.StrainVector));
+            permeability_update_factors.push_back(this->CalculatePermeabilityUpdateFactor(strain_vectors[GPoint]));


Ah, this could be a transform now

WPK4FEM

Good to go.

avdg81

This looks like a nice improvement to me. I have no further suggestions.

avdg81 · 2024-05-13T14:27:07Z

applications/GeoMechanicsApplication/custom_elements/U_Pw_small_strain_element.cpp

+        const auto deformation_gradients = CalculateDeformationGradients();
+        rOutput = CalculateStrains(deformation_gradients, b_matrices, Variables.DisplacementVector,
+                                   Variables.UseHenckyStrain);


Very nice cleanup :-)

rfaasse added 16 commits May 7, 2024 11:11

Changed signature of `SmallStrainUPwDiffOrderElement::CalculateCauchy…

7061c42

…Strain` to return a vector and takes relevant inputs instead of variables

Changed signature of UPwSmallStrainElement::CalculateStrain to retu…

5dc686a

…rn a vector and takes relevant inputs instead of variables

Changed signature of CalculateStrain (diff order and non-diff order…

ce511b3

…) to return a vector instead of using the ElementVariables

Changed signature of CalculateStrain (diff order) to input the defo…

63bd1a6

…rmation gradient, instead of getting it from ElementVariables

Actually use deformation gradient that was passed on via arguments

5f451f1

Changed signature of CalculateStrain (non-diff order) to input the …

5827e2c

…deformation gradient, instead of getting it from ElementVariables

Merge remote-tracking branch 'origin/master' into geo/12319-extract-s…

58b5bd6

…train-vector-calculations

Changed signature of CalculateStrain (diff order) to input the b ma…

05fd57f

…trix, displacements and UseHenckyStrainFlag instead of using ElementVariables

Changed signature of CalculateStrain (non-diff order) to input the …

7f65441

…b matrix, displacements and UseHenckyStrainFlag instead of using ElementVariables

Removed some redundant calculations of the determinant of F

dcc3bac

Merge remote-tracking branch 'origin/master' into geo/12319-extract-s…

a34346b

…train-vector-calculations

Created CalculateDeformationGradients for diff order element, and u…

258c65c

…sed it to calculate lists up front

Created CalculateDeterminantsOfDeformationGradients for diff order …

770d373

…element, and used it to calculate lists up front

Created CalculateStrains for diff order element, and used it to cal…

76f70a5

…culate lists up front

Rewrote CalculateStrains using std::transform

3daae8e

Removed blank line

a0c560d

Base automatically changed from geo/12319-extract-strain-vector-calculations to master May 10, 2024 11:30

rfaasse added 3 commits May 10, 2024 14:06

Merge remote-tracking branch 'origin/master' into geo/12319-extract-s…

828e621

…train-and-F-lists

Removed static member accessed through instance

802fd1a

Merge remote-tracking branch 'origin/master' into geo/12319-extract-s…

e798262

…train-and-F-lists

rfaasse changed the title ~~Geo/12319 extract strain and f lists~~ [GeoMechanicsApplication] Extract pre-calculated lists for strain vectors and (determinants of) deformation gradients May 13, 2024

rfaasse added 2 commits May 13, 2024 09:50

Added calculation functions for lists of deformation gradients, deter…

c5bf6b4

…minants and strain vectors to U_Pw_small_strain_element.hpp

Calculated lists for the upw small strain element

8906177

rfaasse marked this pull request as ready for review May 13, 2024 09:13

rfaasse requested review from avdg81, WPK4FEM and markelov208 May 13, 2024 09:13

markelov208 reviewed May 13, 2024

View reviewed changes

WPK4FEM reviewed May 13, 2024

View reviewed changes

rfaasse self-assigned this May 13, 2024

rfaasse added GeoMechanics Issues related to the GeoMechanicsApplication Refactor When code is moved or rewrote keeping the same behavior labels May 13, 2024

rfaasse added 6 commits May 13, 2024 13:23

Merge remote-tracking branch 'origin/master' into geo/12319-extract-s…

19eb9dc

…train-and-F-lists

Renamed FourthOrderTensorType

b89bfbf

Split math_utilities into header and source and created new function …

0aa589f

…for calculating the determinants of a list of matrices

Use the new math utility function in both diff-order and non-diff-ord…

862f500

…er elements.

Added unit tests for math utility function

1482111

Merge remote-tracking branch 'origin/master' into geo/12319-extract-s…

18a93b4

…train-and-F-lists

rfaasse requested review from markelov208 and WPK4FEM May 13, 2024 13:57

markelov208 approved these changes May 13, 2024

View reviewed changes

rfaasse commented May 13, 2024

View reviewed changes

rfaasse mentioned this pull request May 13, 2024

[GeoMechanicsApplication] Inlined member functions SetRetentionParameters #12374

Merged

WPK4FEM approved these changes May 13, 2024

View reviewed changes

avdg81 approved these changes May 13, 2024

View reviewed changes

rfaasse enabled auto-merge (squash) May 13, 2024 15:14

rfaasse merged commit c2a05d7 into master May 13, 2024
11 checks passed

rfaasse deleted the geo/12319-extract-strain-and-F-lists branch May 13, 2024 15:44

rfaasse linked an issue May 14, 2024 that may be closed by this pull request

[GeoMechanicsApplication] Split the calculation of the inputs for the utility functions for element matrices and the calling of the functions #12319

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GeoMechanicsApplication] Extract pre-calculated lists for strain vectors and (determinants of) deformation gradients #12363

[GeoMechanicsApplication] Extract pre-calculated lists for strain vectors and (determinants of) deformation gradients #12363

rfaasse commented May 8, 2024 •

edited

Loading

markelov208 left a comment

WPK4FEM left a comment

WPK4FEM May 13, 2024

rfaasse May 13, 2024

WPK4FEM May 13, 2024

rfaasse May 13, 2024

rfaasse May 13, 2024

WPK4FEM May 13, 2024

rfaasse May 13, 2024

markelov208 left a comment

rfaasse May 13, 2024

WPK4FEM left a comment

avdg81 left a comment

avdg81 May 13, 2024

		@@ -547,11 +556,9 @@ void SmallStrainUPwDiffOrderElement::FinalizeSolutionStep(const ProcessInfo& rCu
		Variables.B = b_matrices[GPoint];

[GeoMechanicsApplication] Extract pre-calculated lists for strain vectors and (determinants of) deformation gradients #12363

[GeoMechanicsApplication] Extract pre-calculated lists for strain vectors and (determinants of) deformation gradients #12363

Conversation

rfaasse commented May 8, 2024 • edited Loading

markelov208 left a comment

Choose a reason for hiding this comment

WPK4FEM left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

markelov208 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

WPK4FEM left a comment

Choose a reason for hiding this comment

avdg81 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rfaasse commented May 8, 2024 •

edited

Loading