[GeoMechanicsApplication] Inlined member functions SetRetentionParameters
#12374
Conversation
These member functions only set the fluid pressure (taken from the `ElementVariables` data structure) that is kept by the retention law parameters. This simple action does not need another level of indirection. Furthermore, it was found that in one location the fluid pressure was calculated, but its result was not stored. Now it is. Also marked a few member functions `[[nodiscard]]`, to trigger warnings when the returned result is discarded. Finally, a few more member functions have been made `const`.
There was a problem hiding this comment.
Anne, a small change but minus a function with unclear name. I included CalculateFluidPressure function content in transport_equation_utilities to calculate a permeability matrix. The content is the same for all elements, the input is slightly different. Would it be useful to place CalculateFluidPressure as a function in trasnport_equition_utilities? Thank you.
There was a problem hiding this comment.
Hi Anne,
This cuts one intermediate step from setting the integration point water pressure in the retention law parameters. That is o.k, it makes it more straightforward.
However, a desirable situation for me is the following. The parameters of the saturation law is the user material input. Water pressure is the independent variable that should be passed to the functions for computation of Saturation, Effective Saturation, Bishop coefficient etc. Somewhere in the retention laws, I read about interpolation polynomials. The interpolation polynomials should remain in the elements and not be anywhere in the retention laws.
So much for future wishes.
Regards,
Wijtze Pieter
📝 Description
These member functions only set the fluid pressure (taken from the
ElementVariablesdata structure) that is kept by the retention law parameters. This simple action does not need another level of indirection.🆕 Changelog
Other changes include:
[[nodiscard]], to trigger warnings when the returned result is discarded.const.