-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MappingApplication] Fixing pure 2D geometry in 2D-3D projection mapper #12847
Merged
loumalouomega
merged 39 commits into
master
from
mapping/fixing-pure-2d-geometry-in-pure-2D-3D-projection-mapper
Nov 14, 2024
Merged
[MappingApplication] Fixing pure 2D geometry in 2D-3D projection mapper #12847
loumalouomega
merged 39 commits into
master
from
mapping/fixing-pure-2d-geometry-in-pure-2D-3D-projection-mapper
Nov 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loumalouomega
added
Applications
Hotfix
FastPR
This Pr is simple and / or has been already tested and the revision should be fast
Bugfix
labels
Nov 14, 2024
approving as this looks as a small detail and its kind of urgent for us. If you have any comments, we can create a new PR @philbucher |
ddiezrod
previously approved these changes
Nov 14, 2024
@roigcarlo do you think it is possible to make a minor, tiny, little, release? |
Once it's merged, no problem |
…dized GMock functionality for one set of unit tests (#12841)
…-3D-projection-mapper
ddiezrod
approved these changes
Nov 14, 2024
loumalouomega
deleted the
mapping/fixing-pure-2d-geometry-in-pure-2D-3D-projection-mapper
branch
November 14, 2024 16:42
@roigcarlo this is merged. It is actually only two commits. Due to a merge conflicts it looks like more: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Applications
Bugfix
FastPR
This Pr is simple and / or has been already tested and the revision should be fast
Hotfix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
The 2D/3D mapper performs projections based on a normal, which is computed in the 2D mesh. Previously, I was supplying a 2D mesh in a 3D space. However, when the space is 2D, the mapper fails due to an error in the
Normal
implementation. This error occurs when the geometry checks if the local space is smaller than the working space.To fix this, I added a check to determine if the geometry is a pure 2D mesh. If so, a normal vector is now explicitly defined in the Z direction, ensuring the projection works correctly even in 2D space.
🆕 Changelog