Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: KCheckedListbox & KListBox do not respect 'disabled' back colours #1573

Closed
PWagner1 opened this issue Jun 25, 2024 · 7 comments
Closed
Labels
area:themes All things to do with themes. area:toolkit All issues related to the toolkit components. bug Something isn't working completed This issue has been completed. version:90 All things to do with V90.
Milestone

Comments

@PWagner1
Copy link
Contributor

While investigating #371, it was found that KCheckedListbox & KListBox (and possibly other controls) do not respect 'disabled' back colours, opting to use 'normal' colours.

@PWagner1 PWagner1 added bug Something isn't working area:themes All things to do with themes. area:toolkit All issues related to the toolkit components. labels Jun 25, 2024
@Smurf-IV Smurf-IV self-assigned this Jun 29, 2024
@Smurf-IV Smurf-IV added the under investigation This bug/issue is currently under investigation. label Jun 29, 2024
@Smurf-IV
Copy link
Member

@Wagnerp Curious, because when set directly it does use the colour from the designer:
image

I'll see what else I can find

@Smurf-IV
Copy link
Member

Currently: I think that the minimal code change to allow the colours to works as expected, will be to change these to be the defaults:
image

I've got some testing to do !

@Smurf-IV
Copy link
Member

BackStyle == Panel is not right, as this is an "Input Control"

@PWagner1
Copy link
Contributor Author

BackStyle == Panel is not right, as this is an "Input Control"

Is this the same for other affected controls?

@Smurf-IV
Copy link
Member

Smurf-IV commented Jun 30, 2024

Is this the same for other affected controls?

Yes (And no). e.g. for a textBox: There is no BackStyle, But the whole control is done via:
image
AND, for a textBox, even tho it has "AlwaysActive" set, it does not override the display state when disabled (Like it does in the ListBox!) Is this a bug with the textBox ?

The Minefield continues.

@Smurf-IV
Copy link
Member

Is this the same for other affected controls?

Turns out:
A number of controls being modified will be in the PR

@Smurf-IV
Copy link
Member

Fixed...
Before:
image

After:
image

Note: ListView(s) will be done in the linked bug

Smurf-IV added a commit that referenced this issue Jun 30, 2024
…ol, over the `AlwaysActive` highlight state.

- Update TestForm to show Enabled states for affected controls

#1573
@Smurf-IV Smurf-IV removed their assignment Jun 30, 2024
@Smurf-IV Smurf-IV added completed This issue has been completed. and removed under investigation This bug/issue is currently under investigation. labels Jun 30, 2024
@Smurf-IV Smurf-IV added this to the Version 90 milestone Jun 30, 2024
@Smurf-IV Smurf-IV added the version:90 All things to do with V90. label Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:themes All things to do with themes. area:toolkit All issues related to the toolkit components. bug Something isn't working completed This issue has been completed. version:90 All things to do with V90.
Projects
None yet
Development

No branches or pull requests

2 participants