-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Office 365 Black theme ribbon needs better colours for disabled etc. #371
Comments
Also note #237 |
Text colour change... black maybe? |
No, should be white like panel text is |
@Smurf-IV Why isn't this being used? |
ribbonText is probably not the same as "disabled ribbon label" text ?? |
Can I remove it, as it's confusing things? |
No, As ribbonText is probably for the text buttons / or the ribbon group text, or some of the above, or something else.. |
This has been driving me crazy, been trying to alter different values to no avail! |
2 things
|
I'll have a look again tomorrow |
@Smurf-IV Ok, so I've found the code that deals with the disabled text colour, BUT if I change it to white, it'll affect all O365 themes. Should I continue? Edit: I might be able to do a 'hack' based on |
NO, Because "White" is the active colour text for dark themes |
So, what colour should it be? |
That's the "new" 365 theme from 2020 ish onwards (i.e. flat and boring) |
Unless the ribbon background is black... black, instead of being greyish. It'll definitely make the disabled text more legible, instead in doing a sweeping theme change. Still haven't found where the CB dropdown colours are located. As for #376, I may undo the changes in KMan & start again tomorrow ;) |
Had a thought... create a special 'Black Theme' base! |
@Smurf-IV Is this ok? |
What is supposed to be disabled, Bright orange is not a disabled colour. |
Umm... difficult to find a colour suitable for a pale greyish background |
The other option would be to use this: https://paletton.com/#uid=14Y0u0kecqd5bGZ9tv9j8lDnBha |
Make " pale greyish background" a darker background, |
I'll possibly rename the variable to make it clearer |
Enabled state , already known one state for controls like textboxes / input controls (light background or so) |
Added a custom control which hosts a checked listbox Application_Menu_PRHwTilhU5.mp4 |
Hi @Wagnerp , I've extended the page to give a complete overview. I've forked it on my account and you can try it from there (mind the branch): Application_Menu_FBcACk194r.mp4 |
Hi @giduac Is there a chance to copy it over to the |
Give it a try first... This will be a good aid to get the Black 365 fine-tuning right.... |
Hi @giduac Just a thought... the current 'normal' input control colours should be used as the 'disabled' colours & the 'normal' colours should be darker. See |
@Wagnerp one state for controls like textboxes / input controls (light background or so) Try inverting first as a starting point. |
I've inverted the colours Background (disabled) should be: #666666 Text ": White Useful tool https://pinetools.com/invert-color |
Is that useful in this case? |
@Wagnerp |
@Wagnerp |
Hi @Smurf-IV Was that the second image, as the link is broken? |
Replaced with direct image insert |
Disabled text
Disabled Combo's
Unfocused tabs
Using 2108.1
The text was updated successfully, but these errors were encountered: