Skip to content

Commit

Permalink
Corrected target/current state logs; added more log statements
Browse files Browse the repository at this point in the history
  • Loading branch information
KyleBoyer committed Aug 2, 2024
1 parent cd9fe82 commit a757c11
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"private": false,
"displayName": "Konnected BlaQ",
"name": "homebridge-blaq",
"version": "0.2.26",
"version": "0.2.27",
"description": "Control and view your garage door(s) remotely with real-time updates using Konnected's BlaQ hardware",
"license": "Apache-2.0",
"type": "module",
Expand Down
7 changes: 4 additions & 3 deletions src/accessory/garage-door.ts
Original file line number Diff line number Diff line change
Expand Up @@ -147,11 +147,11 @@ export class BlaQGarageDoorAccessory extends BaseBlaQAccessory {
return this.platform.characteristic.CurrentDoorState.OPENING;
} else if (this.state === 'OPEN' || (this.position !== undefined && this.position > 0)) {
const openReason = this.state === 'OPEN' ? 'the current state is OPEN' : 'the current position is greater than zero';
this.logger.debug(`Returning current state OPENING because: ${openReason}`);
this.logger.debug(`Returning current state OPEN because: ${openReason}`);
return this.platform.characteristic.CurrentDoorState.OPEN;
} else if (this.state === 'CLOSED' || (this.position !== undefined && this.position <= 0)) {
const closedReason = this.state === 'CLOSED' ? 'the current state is CLOSED' : 'the current position is less than or equal to zero';
this.logger.debug(`Returning current state OPENING because: ${closedReason}`);
this.logger.debug(`Returning current state CLOSED because: ${closedReason}`);
return this.platform.characteristic.CurrentDoorState.CLOSED;
}
throw new Error(`Invalid door state: ${this.state}`);
Expand Down Expand Up @@ -253,10 +253,11 @@ export class BlaQGarageDoorAccessory extends BaseBlaQAccessory {
this.logger.debug('Returning target state CLOSED because: current operation is IDLE and current state is CLOSED');
return this.platform.characteristic.TargetDoorState.CLOSED;
}else if(this.state === 'OPEN'){
this.logger.debug('Returning target state CLOSED because: current operation is IDLE and current state is OPEN');
this.logger.debug('Returning target state OPEN because: current operation is IDLE and current state is OPEN');
return this.platform.characteristic.TargetDoorState.OPEN;
}
}
this.logger.debug('Returning target state CLOSED because: no other conditions matched');
return this.platform.characteristic.TargetDoorState.CLOSED;
// throw new Error(`Invalid target door state: ${this.currentOperation}`);
}
Expand Down

0 comments on commit a757c11

Please sign in to comment.