Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VlenUtf8, VlenBytes, VlenArray codecs and make VlenV2Codec private #115

Closed
5 tasks
LDeakin opened this issue Dec 30, 2024 · 0 comments · Fixed by #119
Closed
5 tasks

Add VlenUtf8, VlenBytes, VlenArray codecs and make VlenV2Codec private #115

LDeakin opened this issue Dec 30, 2024 · 0 comments · Fixed by #119
Labels
good first issue Good for newcomers
Milestone

Comments

@LDeakin
Copy link
Owner

LDeakin commented Dec 30, 2024

Since zarr-python has settled on data-type dependent names for the vlen codec (vlen-utf8, vlen-bytes) instead of something like vlen_v2, I might as well tighten this API:

  • Add VlenUtf8 (VlenV2Codec with "vlen-utf8" name)
  • Add VlenBytes (VlenV2Codec with "vlen-bytes" name)
  • Add VlenArray (VlenV2Codec with "vlen-array" name)
  • Make VlenV2Codec pub(crate) or just publicly deprecate
  • Remove instances of vlen_v2 in the docs, and add vlen-utf8 etc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant