Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: make VLenV2Codec private, add VLen{Array,Bytes,Utf8}Codec #119

Merged
merged 3 commits into from
Jan 1, 2025

Conversation

LDeakin
Copy link
Owner

@LDeakin LDeakin commented Jan 1, 2025

Closes #115

Copy link

codecov bot commented Jan 1, 2025

Codecov Report

Attention: Patch coverage is 65.04854% with 36 lines in your changes missing coverage. Please review.

Project coverage is 81.61%. Comparing base (698fb83) to head (2b37e0a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ray/codec/array_to_bytes/vlen_v2/vlen_v2_macros.rs 65.21% 32 Missing ⚠️
zarrs/src/array/codec/array_to_bytes/vlen_v2.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
- Coverage   81.68%   81.61%   -0.08%     
==========================================
  Files         166      166              
  Lines       23756    23826      +70     
==========================================
+ Hits        19406    19445      +39     
- Misses       4350     4381      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LDeakin LDeakin merged commit 7851ce6 into main Jan 1, 2025
22 checks passed
@LDeakin LDeakin deleted the vlen_v2_explicit branch January 1, 2025 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add VlenUtf8, VlenBytes, VlenArray codecs and make VlenV2Codec private
1 participant