Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed lsst para file #52

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

raphaelshirley
Copy link
Collaborator

@raphaelshirley raphaelshirley commented Jun 12, 2024

This is now included in the Python code which overrides the default COSMOS example

Closes #44

Need to check that all the notebooks and examples run without it.

Problem & Solution Description (including issue #)

We were originally working on shipping the para file with the pip distribution. However we later decided it was cleaner to include the original COSMOS example in the lephare pip Python code so here it can simply be imported and overidden with the default values in the algos file or otherwise sent to the inform stage.

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

Need to check that all the notebooks run without it
@raphaelshirley raphaelshirley self-assigned this Jun 12, 2024
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.57%. Comparing base (3f512c3) to head (0e9f7e7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #52   +/-   ##
=======================================
  Coverage   46.57%   46.57%           
=======================================
  Files           2        2           
  Lines         146      146           
=======================================
  Hits           68       68           
  Misses         78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package lsst.para file for distribution
1 participant