This repository has been archived by the owner on Jul 15, 2022. It is now read-only.
LIVE-1469 Handle onboarded devices in device actions #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/ledgerhq/ledger-live-common/5TercUEt1EqgS5jWiWhpKbeQryaq |
juan-cortes
force-pushed
the
bugfix/LIVE-1469
branch
from
673d94a to
7dca803
Compare
juan-cortes
force-pushed
the
bugfix/LIVE-1469
branch
from
7dca803 to
047a9a0
Compare
gre
approved these changes
Feb 24, 2022
juan-cortes
force-pushed
the
bugfix/LIVE-1469
branch
from
f5a8d32 to
709f587
Compare
valpinkman
approved these changes
Feb 25, 2022
valpinkman
changed the base branch from
develop
to
hotfix/onboarding-lns-LIVE-1469
valpinkman
pushed a commit
that referenced
this pull request
Feb 25, 2022
Merged
valpinkman
added a commit
that referenced
this pull request
Feb 25, 2022
* hotfix/LIVE-1469: v21.32.6 LIVE-1469 Handle onboarded devices in device actions (#1738)
valpinkman
pushed a commit
that referenced
this pull request
Feb 25, 2022
valpinkman
added a commit
that referenced
this pull request
Mar 7, 2022
* release/21.34.0: (24 commits) v21.34.0 Create dependencies.md Filecoin fixes (#1740) Bump url-parse from 1.5.7 to 1.5.10 in /mobile-test-app (#1757) Bump url-parse from 1.5.7 to 1.5.10 in /cli (#1758) Bump url-parse from 1.5.7 to 1.5.10 (#1759) Bump url-parse from 1.5.7 to 1.5.10 in /tools (#1760) Bump urijs from 1.19.7 to 1.19.8 in /cli (#1755) Bump urijs from 1.19.7 to 1.19.8 in /mobile-test-app (#1753) Bump urijs from 1.19.7 to 1.19.8 (#1754) Bump urijs from 1.19.7 to 1.19.8 in /tools (#1756) LIVE-1469 Handle onboarded devices in device actions (#1738) bot: filecoin spec: remove specific version Fixes elrond bot LIVE-1462 (#1739) Make node-ble transport optional again (#1736) Update FeatureToggle component types (#1737) Bot: ethereum specs to allow more testTimeout (#1733) Fixes elrond specs bot case of the eGLD ticker on device fix dcr fees (#1734) Update mock API for market tests to support filtering (#1728) ...
valpinkman
added a commit
that referenced
this pull request
Mar 18, 2022
* release/v21.35.0: v21.35.0 v21.34.0 v21.32.6 LIVE-1469 Handle onboarded devices in device actions (#1738)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context (issues, jira)
https://ledgerhq.atlassian.net/browse/LIVE-1469
Description / Usage
The latest firmware version in the upcoming LNS+ and on existing devices allow us to detect a device before it's onboarded but we can't interact with it the normal way because, well, it's not seeded. So we need to handle that case and show a meaningful error message to our users and guide them to the onboarding.
Expectations