Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

LIVE-448 - Update mock API for market tests to support filtering #1728

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

thomasrogerlux
Copy link
Contributor

@thomasrogerlux thomasrogerlux commented Feb 21, 2022

Context (issues, jira)

LIVE-448

Description / Usage

We are currently writing e2e tests with playwright in LLD for the market page. The existing mock API isn't supporting any type of filtering and this PR is fixing that.

Expectations

  • Test coverage: The changes of this PR are covered by test. Unit test were added with mocks when depending on a backend/device.
  • No impact: The changes of this PR have ZERO impact on the userland. Meaning, we can use these changes without modifying LLD/LLM at all. It will be a "noop" and the maintainers will be able to bump it without changing anything.

@thomasrogerlux thomasrogerlux requested a review from a team as a code owner February 21, 2022 15:41
@vercel
Copy link

vercel bot commented Feb 21, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ledgerhq/ledger-live-common/BLzRqwCYEL1pKstQiMETgXQYLzFQ
✅ Preview: https://ledger-live-common-git-support-live-448-market-014248-ledgerhq.vercel.app

@thomasrogerlux thomasrogerlux merged commit 37059a3 into develop Feb 24, 2022
@thomasrogerlux thomasrogerlux deleted the support/LIVE-448-market-page-tests branch February 24, 2022 09:48
valpinkman added a commit that referenced this pull request Mar 7, 2022
* release/21.34.0: (24 commits)
  v21.34.0
  Create dependencies.md
  Filecoin fixes (#1740)
  Bump url-parse from 1.5.7 to 1.5.10 in /mobile-test-app (#1757)
  Bump url-parse from 1.5.7 to 1.5.10 in /cli (#1758)
  Bump url-parse from 1.5.7 to 1.5.10 (#1759)
  Bump url-parse from 1.5.7 to 1.5.10 in /tools (#1760)
  Bump urijs from 1.19.7 to 1.19.8 in /cli (#1755)
  Bump urijs from 1.19.7 to 1.19.8 in /mobile-test-app (#1753)
  Bump urijs from 1.19.7 to 1.19.8 (#1754)
  Bump urijs from 1.19.7 to 1.19.8 in /tools (#1756)
  LIVE-1469 Handle onboarded devices in device actions (#1738)
  bot: filecoin spec: remove specific version
  Fixes elrond bot LIVE-1462 (#1739)
  Make node-ble transport optional again (#1736)
  Update FeatureToggle component types (#1737)
  Bot: ethereum specs to allow more testTimeout (#1733)
  Fixes elrond specs bot case of the eGLD ticker on device
  fix dcr fees (#1734)
  Update mock API for market tests to support filtering (#1728)
  ...
aimxhaisse pushed a commit to skillz-blockchain/ledger-live-common that referenced this pull request Mar 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant