Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

LIVE-2162 Solana fixes after initial staking #1947

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Conversation

ghost
Copy link

@ghost ghost commented May 9, 2022

ℹ️ Note: requires LedgerHQ/ledger-live-desktop#4969

Context (issues, jira)

https://ledgerhq.atlassian.net/browse/LIVE-2162

Description / Usage

Specs of the changes are described here: https://docs.google.com/document/d/1QvlLnoLBkXZ3xul7cHajYzqVjolSTj0tJ64YPfkjvG8/edit

Expectations

  • Test coverage: The changes of this PR are covered by test. Unit test were added with mocks when depending on a backend/device.
  • No impact: The changes of this PR have ZERO impact on the userland. Meaning, we can use these changes without modifying LLD/LLM at all. It will be a "noop" and the maintainers will be able to bump it without changing anything.

* solana introduce tx confirmation timeout env var

* solana increase http delay between requests to 500

* solana fix seq number for optimistic op

* solana switch to random seed for staking accs

* solana stop caching prepareTx

* solana fix op tx seq number

* solana fix lint

* solana filter out non profitable validators on mainnet

* solana update deps

* solana update deprecated usage of deps

* solana make acc balance include staked amounts

* solana make some broadcast errors more user friendly

* solana add use all amount stake warning

* solana replace deprecated fee calculator

* solana make validators ordered by score

* solana update deps

* solana fix estimate max spendable

* solana set blockhash cache time to 15 secs

* solana add retry logic for estimate tx fee

* solana export stake actions types

* solana update deps
@ghost ghost self-requested a review as a code owner May 9, 2022 20:31
@vercel
Copy link

vercel bot commented May 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ledger-live-common ✅ Ready (Inspect) Visit Preview May 13, 2022 at 4:12PM (UTC)

@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #1947 (b44e2ae) into develop (6a2af82) will increase coverage by 0.08%.
The diff coverage is 65.34%.

@@             Coverage Diff             @@
##           develop    #1947      +/-   ##
===========================================
+ Coverage    59.42%   59.51%   +0.08%     
===========================================
  Files          510      512       +2     
  Lines        21105    21139      +34     
  Branches      5687     5700      +13     
===========================================
+ Hits         12541    12580      +39     
+ Misses        8543     8536       -7     
- Partials        21       23       +2     
Impacted Files Coverage Δ
src/env.ts 65.21% <ø> (ø)
src/exchange/swap/getProviders.ts 58.33% <0.00%> (ø)
src/families/cosmos/validators.ts 61.15% <ø> (ø)
src/families/ripple/test-dataset.ts 100.00% <ø> (ø)
src/families/solana/js-signOperation.ts 8.57% <0.00%> (-0.43%) ⬇️
src/families/solana/logic.ts 33.84% <ø> (ø)
src/families/solana/bridge/mock.ts 29.62% <7.69%> (-3.71%) ⬇️
src/families/cosmos/js-signOperation.ts 16.66% <14.28%> (-2.46%) ⬇️
src/families/solana/api/logged.ts 7.69% <14.28%> (+0.54%) ⬆️
src/families/solana/js-broadcast.ts 22.22% <14.28%> (-6.35%) ⬇️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5fd297...b44e2ae. Read the comment docs.

konoart and others added 2 commits May 11, 2022 16:42
* solana switch to translatable errors

* solana make bot transfer amount integer
@ghost ghost added the feature ready label May 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants