This repository has been archived by the owner on Jul 15, 2022. It is now read-only.
LIVE-1292 Cover Polkadot existential deposit edge case #1953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Send max must be balances.transfer palletMethod instead of balances.transferKeepAlive
On the Polkadot network, an address is only active when it holds a minimum amount, currently set at 1 DOT. There's a limitation when you hold ~ 1 DOT. Use recommended 1.1 DOT value.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
henri-ly
approved these changes
May 12, 2022
ghost
suggested changes
May 12, 2022
Don't use ternary operator
Restore EXISTENTIAL_DEPOSIT, use new constant EXISTENTIAL_DEPOSIT_RECOMMENDED_MARGIN to handle recommended margin
Codecov Report
@@ Coverage Diff @@
## develop #1953 +/- ##
===========================================
- Coverage 69.14% 59.46% -9.68%
===========================================
Files 545 510 -35
Lines 23534 21132 -2402
Branches 6194 5693 -501
===========================================
- Hits 16273 12567 -3706
- Misses 7219 8543 +1324
+ Partials 42 22 -20
Continue to review full report at Codecov.
|
ghost
changed the title
ghost
deleted the
LIVE-1292-failed-to-submit-transaction-when-trying-to-empty-account-with-1-dot
branch
ghost
pushed a commit
that referenced
this pull request
May 16, 2022
* LIVE-1292 Cover Polkadot existential deposit edge case (#1953) * Fix transaction mode mapping Send max must be balances.transfer palletMethod instead of balances.transferKeepAlive * Fix 1 DOT Polkadot limitation On the Polkadot network, an address is only active when it holds a minimum amount, currently set at 1 DOT. There's a limitation when you hold ~ 1 DOT. Use recommended 1.1 DOT value. * Improve code readability Don't use ternary operator * Split Existential Deposit and margin Restore EXISTENTIAL_DEPOSIT, use new constant EXISTENTIAL_DEPOSIT_RECOMMENDED_MARGIN to handle recommended margin * Polkabot * trigger bot * trigger bot * Change Polkadot bot to 'Mooncake' seed * Change Polkadot bot to 'Mere Denis' seed * Change Polkadot bot to 'Silicium' seed * Update Polkadot bot spec to withdraw staking funds sometimes * Fix bot condition to do bond transactions * trigger bot * trigger bot * trigger bot * trigger bot * trigger bot * lint - remove unused import Co-authored-by: Alexandre Alouit <[email protected]>
ghost
mentioned this pull request
3 tasks
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context (issues, jira)
https://ledgerhq.atlassian.net/browse/LIVE-1292
Description / Usage
When trying to emptied an account, it doesn't work.
This happens when the balance is at ~1 DOT, this is a limitation of the Polkadot blockchain.
The logic of Ledger Live Common was not adapted, this PR fix this.
This PR also contains a fix on the optimistic operation which does not contain the correct type when it is a send max.
Expectations