Fix: LIVE-8553 polkadot not enough balance error

[hzheng-ledger]

📝 Description

-. Steps to Reproduce the bug:

An account of Polkadot with available balance between 0-1 DOT and enough bonded balance (or unbonded balance) >1 DOT

Try to send funds (e.g. 0.5 DOT) from this account.

-. Expected behavior:

We should be able to send funds from this account because it is lower than “send max” balance.

-. Actual behavior:

"Not enough balance" error.

In our old code, we had such check that raises the NotEnoughBalance error which is not correct.

if (
      !errors.amount &&
      !t.useAllAmount &&
      a.spendableBalance.lte(EXISTENTIAL_DEPOSIT.plus(EXISTENTIAL_DEPOSIT_RECOMMENDED_MARGIN))
    ) {
      errors.amount = new NotEnoughBalance();
    }

In this PR, I've removed this check and added getTransactionStatus.unit.test.ts to cover this bug.
Also, I've done some refactoring for polkadot family.

❓ Context

• Impacted projects: LLC
• Linked resource(s): https://ledgerhq.atlassian.net/browse/LIVE-8553

✅ Checklist

• Test coverage
• Atomic delivery
• No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

[changeset-bot]

🦋 Changeset detected

Latest commit: 2b67b06

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages

Name	Type
@ledgerhq/coin-polkadot	Patch
@ledgerhq/live-common	Patch
@ledgerhq/live-cli	Patch
ledger-live-desktop	Patch
live-mobile	Patch
@ledgerhq/test-utils	Patch
dummy-wallet-app	Patch
live-common-tools	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
live-common-tools	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 18, 2023 2:36pm
native-ui-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 18, 2023 2:36pm

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
ledger-live-github-bot	⬜️ Ignored (Inspect)	Visit Preview		Jul 18, 2023 2:36pm
react-ui-storybook	⬜️ Ignored (Inspect)			Jul 18, 2023 2:36pm

[ghost]

• Description of the PR is not enough, please describe the exact issue and how it is fixed
• Need to compare with and understand the PR that originally introduced the current code: LIVE-1292 Cover Polkadot existential deposit edge case ledger-live-common#1953
• Need to make sure this is covered with tests. My suggestion:
  • this can easily be covered with the bridge integration tests
  • add here a raw account that has the correct configuration to reproduce the issue
  • add transaction(s) that reproduce the issue, then make sure the issue doesn't happen anymore

[ghost]

LGTM but please run the bot a couple times to be safe. Thanks 🙏

[ghost]

This unit test is literally doing the same that can be done a bit easier as a bridge integration test :)
But I guess the debate is still on, about pros and cons of both...

[github-actions]

There as been no activity on this PR for the last 14 days. Please consider closing this PR.