Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

LIVE-448 - Add playwright test suite for market page #4736

Merged
merged 33 commits into from
Mar 7, 2022
Merged

LIVE-448 - Add playwright test suite for market page #4736

merged 33 commits into from
Mar 7, 2022

Conversation

thomasrogerlux
Copy link
Contributor

@thomasrogerlux thomasrogerlux commented Feb 11, 2022 •
edited by jira bot
Loading

🦒 Context (issues, jira)

LIVE-448

💻 Description / Demo (image or video)

Add test suite for market page (previous PR #4704 got closed by release)

🖤 Expectations to reach

PR must pass CI, merge develop if conflicts, do not force push. Thanks!

  • on QA: at least one of these two checkboxes must be checked:
    • a specific test planned is defined on Jira
    • this PR is covered by automatic UI test
  • on delivery: at least one of these two checkboxes must be checked:
    • Option 1: no impact: The changes of this PR have ZERO impact on the userland (invisible for users)
    • Option 2: atomic delivery: the changes is atomic and complete (no partial delivery)

PR must pass CI, merge develop if conflicts, do not force push. Thanks!

@github-actions
Copy link

github-actions bot commented Feb 11, 2022 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🔴 Statements 8.74% 9/103
🔴 Branches 0% 0/19
🔴 Functions 2.94% 1/34
🔴 Lines 8.33% 8/96

Test suite run success

1 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 0d4214c

@thomasrogerlux
Copy link
Contributor Author

/generate-screenshots

@github-actions
Copy link

Generating new screenshots

@thomasrogerlux thomasrogerlux marked this pull request as ready for review February 21, 2022 16:17
@thomasrogerlux thomasrogerlux requested a review from a team as a code owner February 21, 2022 16:17
@thomasrogerlux thomasrogerlux added the HODL for PRs: this is blocked, we can't merge yet label Feb 22, 2022
@thomasrogerlux
Copy link
Contributor Author

Wait for LedgerHQ/ledger-live-common#1728

@thomasrogerlux thomasrogerlux requested a review from a team as a code owner February 24, 2022 10:20
@thomasrogerlux
Copy link
Contributor Author

/generate-screenshots

@github-actions
Copy link

Generating new screenshots

@thomasrogerlux thomasrogerlux removed the HODL for PRs: this is blocked, we can't merge yet label Feb 24, 2022
@github-actions
Copy link

Generating new screenshots

@thomasrogerlux
Copy link
Contributor Author

/generate-screenshots

@github-actions
Copy link

github-actions bot commented Mar 2, 2022

Generating new screenshots

1 similar comment
@github-actions
Copy link

github-actions bot commented Mar 2, 2022

Generating new screenshots

@nabil-brn nabil-brn self-requested a review March 3, 2022 09:03
@thomasrogerlux
Copy link
Contributor Author

/generate-screenshots

@github-actions
Copy link

github-actions bot commented Mar 3, 2022

Generating new screenshots

@nabil-brn
Copy link
Contributor

/generate-screenshots

@github-actions
Copy link

github-actions bot commented Mar 7, 2022

Generating new screenshots

@nabil-brn
Copy link
Contributor

/generate-screenshots

@github-actions
Copy link

github-actions bot commented Mar 7, 2022

Generating new screenshots

nabil-brn
nabil-brn approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@nabil-brn nabil-brn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, no new screenshots, the tests should not be flaky anymore once we merged this PR.

valpinkman
valpinkman suggested changes Mar 7, 2022
View reviewed changes
Copy link
Member

@valpinkman valpinkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the splitting of the one test I mentionned, everything looks fine to me. Fix this and we will be ready ;)

tests/specs/market.spec.ts Show resolved Hide resolved
@nabil-brn nabil-brn self-requested a review March 7, 2022 13:39
@valpinkman valpinkman merged commit 2090c77 into develop Mar 7, 2022
@valpinkman valpinkman deleted the LIVE-448 branch March 7, 2022 14:09
Arnaud97234 pushed a commit that referenced this pull request Mar 7, 2022
@thomasrogerlux @ledgerlive
@nabil-brn @Arnaud97234
LIVE-448 - Add playwright test suite for market page (#4736)
5ac4fc3 
* Add playwright test suite for market page

* update screenshots (linux)

* update screenshots (windows)

* update screenshots (windows)

* update screenshots (linux)

* update screenshots (windows)

* Fix screenshots

* Update market tests

* update screenshots (linux)

* update screenshots (windows)

* update screenshots (windows)

* Fix conflicts

* Update LLC

* update screenshots (linux)

* update screenshots (linux)

* update screenshots (linux)

* ci run

* Fix merge

* update screenshots (windows)

* market page tests

* update screenshots (linux)

* update screenshots (windows)

* last ci run

* Split sorting test step in two

Co-authored-by: Team Live <[email protected]>
Co-authored-by: Nabil Bourenane <[email protected]>
LFBarreto pushed a commit that referenced this pull request Mar 10, 2022
@thomasrogerlux @ledgerlive
@nabil-brn @LFBarreto
LIVE-448 - Add playwright test suite for market page (#4736)
2a85f30 
* Add playwright test suite for market page

* update screenshots (linux)

* update screenshots (windows)

* update screenshots (windows)

* update screenshots (linux)

* update screenshots (windows)

* Fix screenshots

* Update market tests

* update screenshots (linux)

* update screenshots (windows)

* update screenshots (windows)

* Fix conflicts

* Update LLC

* update screenshots (linux)

* update screenshots (linux)

* update screenshots (linux)

* ci run

* Fix merge

* update screenshots (windows)

* market page tests

* update screenshots (linux)

* update screenshots (windows)

* last ci run

* Split sorting test step in two

Co-authored-by: Team Live <[email protected]>
Co-authored-by: Nabil Bourenane <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nabil-brn nabil-brn nabil-brn approved these changes

@LFBarreto LFBarreto LFBarreto approved these changes

@valpinkman valpinkman valpinkman approved these changes

Assignees
No one assigned
Labels
QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thomasrogerlux @nabil-brn @valpinkman @LFBarreto @ledgerlive